The tool failed to properly resolve nested local dependencies to jsonnet
bundles in different directory trees. This arises because the
installation command resolves and installs nested jsonnet local
dependencies relative to the root jsonnetfile, rather than track and
evaluate the installation path relative to the nested library's
jsonnetfile.
Consider a repository with multiple local jsonnet bundles in various
directory trees, organised as follows (lockfiles elided for brevity):
/top/of/tree
|- lib/module_A
|- jsonnetfile.json
|- lib/module_B
|- jsonnetfile.json
|- src/root_module
|- jsonnetfile.json
The modules depend on each other as follows:
┌───────────────────┐ ┌───────────────────┐ ┌───────────────────┐
│ │ │ │ │ │
│ src/root_module │──>│ lib/module_A │──>│ lib/module_B │
│ │ │ │ │ │
└───────────────────┘ └───────────────────┘ └───────────────────┘
where X ──> Y indicates bundle X depends on bundle Y, expressed by
adding a dependency of type local in bundle X's jsonnetfile.json, whose
path is the relative path from bundle X to bundle Y in the directory
structure. For example, src/root_module will express a local dependency
on path ../lib/module_A to depend on library module A.
Invoking jb install in src/root_module will result in an error:
jb: error: failed to install packages: downloading: symlink destination path does not exist: %w:
stat /top/of/tree/src/module_B: no such file or directory
This occurs because jsonnet-bundler improperly attempts to resolve the
nested dependency on library module B relative to the root module path,
i.e. src/root_module. The correct behaviour is to perform such
resolution relative to the depending module's jsonnetfile.json, i.e.
relative to lib/module_A.
* Enhancement: Subdir detect runtime os. If windows changes "\" to "/"
* Bug fix: for compare known, on windows, use "\" instead of "/"
* Bug fix: for compare known, on windows, use "\" instead of "/"
Co-authored-by: c0feec0der <>
* use filepath to check for known packages
this fixes an issue using windows. without this patch, jb would delete
the folder after installation since the path is not known
* reduce temp directory length by hashing
using this hash it is harder to reach the windows limit for filenames
and directories
* further reduce temp dir length
* do not build binaries for windows/amd*
The vendor dir (here called "dir") is already joined with the CWD
in installCommand(). it should not be joined again here.
Also adds a logging message to show that a local package was
installed.
Allows `installing` a package without pulling dependencies of that
package. This comes in handy when having multiple directories on
`JPATH`, which overlay each other.
Because dependencies may be already present at lesser ranked import
paths, it's not required to pull them, when only needing to bump a
single one.
Several code-hosters like GitLab allow to have subgroups. These were previously not suppported because we weren't able to tell if something was a subgroup or a subdir.
By letting users specify the `.git` part of the http string as well, this now work for all protocol, including https.
