technofab/zfs-localpv
1
0
Fork 0
mirror of https://github.com/TECHNOFAB11/zfs-localpv.git synced 2025-12-12 06:20:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

chore(go-lint): fix golint warning (#133)

Browse source 
Fixes several go lint cases reported by go report. 

Signed-off-by: wiwen <shenggxhz@gmail.com>
This commit is contained in:
wiwen 2020-06-09 17:17:23 +08:00 • committed by GitHub
parent 639ead416e
commit f5ae3ff476
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
25 changed files with 78 additions and 51 deletions
Download patch file Download diff file Expand all files Collapse all files

14
pkg/usage/const.go
View file

@ -21,26 +21,28 @@ const (
// supported events categories
// Install event is sent on pod starts
// InstallEvent event is sent on pod starts
InstallEvent string = "install"
// Ping event is sent periodically
Ping string = "zfs-ping"
// VolumeProvision event is sent when a volume is created
VolumeProvision string = "volume-provision"
//VolumeDeprovision event is sent when a volume is deleted
// VolumeDeprovision event is sent when a volume is deleted
VolumeDeprovision string = "volume-deprovision"
AppName string = "OpenEBS"
// AppName the application name
AppName string = "OpenEBS"
// RunningStatus status is running
RunningStatus string = "running"
// Event labels
RunningStatus string = "running"
EventLabelNode string = "nodes"
EventLabelCapacity string = "capacity"
// Event action
// Replica Event replication
Replica string = "replica:"
DefaultReplicaCount string = "replica:1"
// Event application name constant for volume event
// DefaultCASType Event application name constant for volume event
DefaultCASType string = "zfs-localpv"
// LocalPVReplicaCount is the constant used by usage to represent

1
pkg/usage/googleanalytics.go
View file

@ -13,6 +13,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package usage
import (

8
pkg/usage/ping.go
View file

@ -22,6 +22,7 @@ import (
"github.com/openebs/zfs-localpv/pkg/common/env"
)
// OpenEBSPingPeriod ping interval of volume io analytics
var OpenEBSPingPeriod = "OPENEBS_IO_ANALYTICS_PING_INTERVAL"
const (
@ -39,7 +40,7 @@ func PingCheck() {
u := New()
duration := getPingPeriod()
ticker := time.NewTicker(duration)
for _ = range ticker.C {
for range ticker.C {
u.Build().
InstallBuilder(true).
SetCategory(Ping).
@ -57,7 +58,8 @@ func getPingPeriod() time.Duration {
if duration < minimumPingPeriod {
// Avoid corner case when the ENV value is undesirable
return time.Duration(defaultPingPeriod)
} else {
return time.Duration(duration)
}
return time.Duration(duration)
}

9
pkg/usage/usage.go
View file

@ -13,6 +13,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package usage
import (
@ -204,7 +205,7 @@ func (u *Usage) Build() *Usage {
return u
}
// Application builder is used for adding k8s&openebs environment detail
// ApplicationBuilder Application builder is used for adding k8s&openebs environment detail
// for non install events
func (u *Usage) ApplicationBuilder() *Usage {
v := NewVersion()
@ -223,7 +224,7 @@ func (u *Usage) SetVolumeCapacity(volCapG string) *Usage {
return u
}
// Wrapper for setting the default storage-engine for volume-provision event
// SetVolumeType Wrapper for setting the default storage-engine for volume-provision event
func (u *Usage) SetVolumeType(volType, method string) *Usage {
if method == VolumeProvision && volType == "" {
// Set the default storage engine, if not specified in the request
@ -234,7 +235,7 @@ func (u *Usage) SetVolumeType(volType, method string) *Usage {
return u
}
// Wrapper for setting replica count for volume events
// SetReplicaCount Wrapper for setting replica count for volume events
// NOTE: This doesn't get the replica count in a volume de-provision event.
// TODO: Pick the current value of replica-count from the CAS-engine
func (u *Usage) SetReplicaCount(count, method string) *Usage {
@ -244,7 +245,7 @@ func (u *Usage) SetReplicaCount(count, method string) *Usage {
u.SetAction(DefaultReplicaCount)
} else {
// Catch all case for volume-deprovision event and
// volume-provision event with an overriden replica-count
// volume-provision event with an overridden replica-count
u.SetAction(Replica + count)
}
return u

1
pkg/usage/versionset.go
View file

@ -13,6 +13,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package usage
import (