technofab/zfs-localpv
1
0
Fork 0
mirror of https://github.com/TECHNOFAB11/zfs-localpv.git synced 2025-12-11 22:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

chore(refactor): move xfs and mount code out of zfs package

Browse source 
Signed-off-by: Pawan <pawan@mayadata.io>
This commit is contained in:
Pawan 2020-11-25 18:49:51 +05:30 • committed by Kiran Mova
parent 935a544538
commit d537bd3655
5 changed files with 86 additions and 59 deletions
Download patch file Download diff file Expand all files Collapse all files

46
pkg/zfs/mount.go
View file

@ -21,6 +21,7 @@ import (
"os/exec"
apis "github.com/openebs/zfs-localpv/pkg/apis/openebs.io/zfs/v1"
mnt "github.com/openebs/zfs-localpv/pkg/mount"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"
"k8s.io/klog"
@ -123,49 +124,6 @@ func UmountVolume(vol *apis.ZFSVolume, targetPath string,
return nil
}
// GetMounts gets mountpoints for the specified volume
func GetMounts(dev string) ([]string, error) {
var (
currentMounts []string
err error
mountList []mount.MountPoint
)
mounter := mount.New("")
// Get list of mounted paths present with the node
if mountList, err = mounter.List(); err != nil {
return nil, err
}
for _, mntInfo := range mountList {
if mntInfo.Device == dev {
currentMounts = append(currentMounts, mntInfo.Path)
}
}
return currentMounts, nil
}
// IsMountPath returns true if path is a mount path
func IsMountPath(path string) bool {
var (
err error
mountList []mount.MountPoint
)
mounter := mount.New("")
// Get list of mounted paths present with the node
if mountList, err = mounter.List(); err != nil {
return false
}
for _, mntInfo := range mountList {
if mntInfo.Path == path {
return true
}
}
return false
}
func verifyMountRequest(vol *apis.ZFSVolume, mountpath string) error {
if len(mountpath) == 0 {
return status.Error(codes.InvalidArgument, "verifyMount: mount path missing in request")
@ -195,7 +153,7 @@ func verifyMountRequest(vol *apis.ZFSVolume, mountpath string) error {
* be unmounted before proceeding to the mount
* operation.
*/
currentMounts, err := GetMounts(devicePath)
currentMounts, err := mnt.GetMounts(devicePath)
if err != nil {
klog.Errorf("can not get mounts for volume:%s dev %s err: %v",
vol.Name, devicePath, err.Error())

111
pkg/zfs/xfs_util.go
View file

@ -1,111 +0,0 @@
/*
Copyright 2020 The OpenEBS Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package zfs
import (
"os"
"os/exec"
"path/filepath"
"strings"
"k8s.io/klog"
)
func xfsTempMount(volume string) error {
device := ZFSDevPath + volume
pvol := strings.Split(volume, "/")
// evaluate the symlink to get the dev path for volume
dev, err := filepath.EvalSymlinks(device)
if err != nil {
return err
}
// create a temporary directory to mount the xfs file system
tmpdir := "/tmp/" + pvol[1]
err = os.Mkdir(tmpdir, 0755)
if os.IsNotExist(err) {
klog.Errorf("xfs: failed to create tmpdir %s error: %s", tmpdir, err.Error())
return err
}
/*
* Device might have already mounted at the tmp path but umount might have failed
* in previous attempt. Checking here if device is not mounted then only attempt
* to mount it, otherwise proceed with the umount.
*/
curMounts, err := GetMounts(dev)
if err != nil {
klog.Errorf("xfs: get mounts failed dev: %s err: %v", device, err.Error())
return err
} else if len(curMounts) == 0 {
// mount with nouuid, so that it can play the log
cmd := exec.Command("mount", "-o", "nouuid", device, tmpdir)
out, err := cmd.CombinedOutput()
if err != nil {
klog.Errorf("xfs: failed to mount volume %s => %s error: %s", device, tmpdir, string(out))
return err
}
} else {
klog.Infof("xfs: device already mounted %s => [%v]", device, curMounts)
}
// log has been replayed, unmount the volume
cmd := exec.Command("umount", tmpdir)
out, err := cmd.CombinedOutput()
if err != nil {
klog.Errorf("xfs: failed to umount tmpdir %s error: %s", tmpdir, string(out))
return err
}
// remove the tmp directory
err = os.Remove(tmpdir)
if err != nil {
// don't return error, reconciliation is not needed as umount is done
klog.Errorf("xfs: failed to remove tmpdir %s error: %s", tmpdir, err.Error())
}
return nil
}
/*
* We have to generate a new UUID for the cloned volumes with xfs filesystem
* otherwise system won't let anyone mount it if UUID is same. Here, since cloned
* volume refers to the same block because of the way ZFS clone works, it will
* also have the same UUID.
* There might be something there in the xfs log, we have to clear them
* so that filesystem is clean and we can generate the UUID for it.
*/
func xfsGenerateUUID(volume string) error {
device := ZFSDevPath + volume
// temporary mount the volume with nouuid to replay the logs
err := xfsTempMount(volume)
if err != nil {
return err
}
// for mounting the cloned volume for xfs, a new UUID has to be generated
cmd := exec.Command("xfs_admin", "-U", "generate", device)
out, err := cmd.CombinedOutput()
if err != nil {
klog.Errorf("xfs: uuid generate failed %s error: %s", volume, string(out))
return err
}
klog.Infof("xfs: generated UUID for the cloned volume %s \n %v", volume, string(out))
return nil
}

7
pkg/zfs/zfs_util.go
View file

@ -24,6 +24,7 @@ import (
apis "github.com/openebs/zfs-localpv/pkg/apis/openebs.io/zfs/v1"
"github.com/openebs/zfs-localpv/pkg/btrfs"
"github.com/openebs/zfs-localpv/pkg/xfs"
k8serrors "k8s.io/apimachinery/pkg/api/errors"
"k8s.io/klog"
"strings"
@ -440,7 +441,8 @@ func CreateClone(vol *apis.ZFSVolume) error {
}
if vol.Spec.FsType == "xfs" {
return xfsGenerateUUID(volume)
device := ZFSDevPath + volume
return xfs.GenerateUUID(device)
}
if vol.Spec.FsType == "btrfs" {
device := ZFSDevPath + volume
@ -814,7 +816,8 @@ func CreateRestore(rstr *apis.ZFSRestore) error {
* so that we can mount it.
*/
if vol.Spec.FsType == "xfs" {
return xfsGenerateUUID(volume)
device := ZFSDevPath + volume
return xfs.GenerateUUID(device)
}
if vol.Spec.FsType == "btrfs" {
device := ZFSDevPath + volume