technofab/zfs-localpv
1
0
Fork 0
mirror of https://github.com/TECHNOFAB11/zfs-localpv.git synced 2025-12-11 22:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(test): fixing resize flaky test case

Browse source 
We are comparing the desired size to the wrong field
because of that resize test is not executing correctly
and sometimes causing test case failure in travis.

The update call is failing sometimes while executing the zfs
property update test cases as for resize also the object
is getting modified. The test case will fail when object updation
happens between volume GET and UPDATE call while performing
zfs property update test case to set various properties on
ZFSVolume resource.

Signed-off-by: Pawan <pawan@mayadata.io>
This commit is contained in:
Pawan 2020-03-26 20:02:03 +05:30 • committed by Kiran Mova
parent 27517c6254
commit 80e4d06860
3 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
ci/ci-test.sh
View file

@ -75,7 +75,7 @@ echo "get all the pods"
kubectl get pods -owide --all-namespaces kubectl get pods -owide --all-namespaces
echo "get pvc and pv details" echo "get pvc and pv details"
kubectl get pvc,pv --all-namespaces kubectl get pvc,pv -oyaml --all-namespaces
echo "get sc details" echo "get sc details"
kubectl get sc --all-namespaces -oyaml kubectl get sc --all-namespaces -oyaml

2
tests/suite_test.go
View file

@ -59,7 +59,7 @@ var (
appPod *corev1.PodList appPod *corev1.PodList
accessModes = []corev1.PersistentVolumeAccessMode{corev1.ReadWriteOnce} accessModes = []corev1.PersistentVolumeAccessMode{corev1.ReadWriteOnce}
capacity = "5368709120" // 5Gi capacity = "5368709120" // 5Gi
NewCapacity = "8589934592" // 8Gi, for testing resize NewCapacity = "8Gi" // 8Gi, for testing resize
KubeConfigPath string KubeConfigPath string
OpenEBSNamespace string OpenEBSNamespace string
) )

6
tests/utils.go
View file

@ -51,7 +51,7 @@ func IsPVCBoundEventually(pvcName string) bool {
// IsPVCResizedEventually checks if the pvc is bound or not eventually // IsPVCResizedEventually checks if the pvc is bound or not eventually
func IsPVCResizedEventually(pvcName string, newCapacity string) bool { func IsPVCResizedEventually(pvcName string, newCapacity string) bool {
newStorage, err := resource.ParseQuantity(NewCapacity) newStorage, err := resource.ParseQuantity(newCapacity)
if err != nil { if err != nil {
return false return false
} }
@ -59,10 +59,10 @@ func IsPVCResizedEventually(pvcName string, newCapacity string) bool {
volume, err := PVCClient. volume, err := PVCClient.
Get(pvcName, metav1.GetOptions{}) Get(pvcName, metav1.GetOptions{})
Expect(err).ShouldNot(HaveOccurred()) Expect(err).ShouldNot(HaveOccurred())
pvcStorage := volume.Spec.Resources.Requests[corev1.ResourceName(corev1.ResourceStorage)] pvcStorage := volume.Status.Capacity[corev1.ResourceName(corev1.ResourceStorage)]
return pvcStorage == newStorage return pvcStorage == newStorage
}, },
60, 5). 120, 5).
Should(BeTrue()) Should(BeTrue())
} }