refact(err): fix unhandled errors (#327)

Signed-off-by: aSquare14 <atibhi.a@gmail.com>
This commit is contained in:
Atibhi Agrawal 2021-05-06 19:28:32 +05:30 committed by GitHub
parent 73d9580817
commit 0f677b6afd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 27 additions and 7 deletions

View file

@ -190,6 +190,8 @@ func (s *nonBlockingGRPCServer) serve(endpoint string, ids csi.IdentityServer, c
klog.Infof("Listening for connections on address: %#v", listener.Addr()) klog.Infof("Listening for connections on address: %#v", listener.Addr())
// Start serving requests on the grpc server created // Start serving requests on the grpc server created
server.Serve(listener) err = server.Serve(listener)
if err != nil {
klog.Fatal(err.Error())
}
} }

View file

@ -57,7 +57,11 @@ func (v *VersionSet) fetchAndSetVersion() error {
if err != nil { if err != nil {
return err return err
} }
env.Set(clusterUUID, v.id)
err = env.Set(clusterUUID, v.id)
if err != nil {
return err
}
k8s, err := k8sapi.GetServerVersion() k8s, err := k8sapi.GetServerVersion()
if err != nil { if err != nil {
@ -66,16 +70,30 @@ func (v *VersionSet) fetchAndSetVersion() error {
// eg. linux/amd64 // eg. linux/amd64
v.k8sArch = k8s.Platform v.k8sArch = k8s.Platform
v.k8sVersion = k8s.GitVersion v.k8sVersion = k8s.GitVersion
env.Set(clusterArch, v.k8sArch)
env.Set(clusterVersion, v.k8sVersion) err = env.Set(clusterArch, v.k8sArch)
if err != nil {
return err
}
err = env.Set(clusterVersion, v.k8sVersion)
if err != nil {
return err
}
v.nodeType, err = k8sapi.GetOSAndKernelVersion() v.nodeType, err = k8sapi.GetOSAndKernelVersion()
if err != nil {
return err
}
env.Set(nodeType, v.nodeType) env.Set(nodeType, v.nodeType)
if err != nil { if err != nil {
return err return err
} }
v.openebsVersion = openebsversion.GetVersionDetails() v.openebsVersion = openebsversion.GetVersionDetails()
env.Set(openEBSversion, v.openebsVersion)
return nil err = env.Set(openEBSversion, v.openebsVersion)
return err
} }
// getVersion is a wrapper over fetchAndSetVersion // getVersion is a wrapper over fetchAndSetVersion