2019-09-12 12:32:17 +05:30
|
|
|
/*
|
|
|
|
|
Copyright © 2019 The OpenEBS Authors
|
|
|
|
|
|
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
|
you may not use this file except in compliance with the License.
|
|
|
|
|
You may obtain a copy of the License at
|
|
|
|
|
|
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
|
|
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
|
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
|
See the License for the specific language governing permissions and
|
|
|
|
|
limitations under the License.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
package driver
|
|
|
|
|
|
|
|
|
|
import (
|
2020-12-10 11:53:16 +05:30
|
|
|
"strings"
|
2020-06-29 12:18:33 +05:30
|
|
|
"sync"
|
|
|
|
|
|
2019-09-12 12:32:17 +05:30
|
|
|
"github.com/container-storage-interface/spec/lib/go/csi"
|
2020-05-22 18:07:17 +05:30
|
|
|
apis "github.com/openebs/zfs-localpv/pkg/apis/openebs.io/zfs/v1"
|
feat(zfspv): adding snapshot and clone support for ZFSPV (#39)
This commits support snapshot and clone commands via CSI driver. User can create snap and clone using the following steps.
Note:
- Snapshot is created via reconciliation CR
- Cloned volume will be on the same zpool where the snapshot is taken
- Cloned volume will have same properties as source volume.
-----------------------------------
Create a Snapshotclass
```
kind: VolumeSnapshotClass
apiVersion: snapshot.storage.k8s.io/v1beta1
metadata:
name: zfspv-snapclass
annotations:
snapshot.storage.kubernetes.io/is-default-class: "true"
driver: zfs.csi.openebs.io
deletionPolicy: Delete
```
Once snapshotclass is created, we can use this class to create a Snapshot
```
apiVersion: snapshot.storage.k8s.io/v1beta1
kind: VolumeSnapshot
metadata:
name: zfspv-snap
spec:
volumeSnapshotClassName: zfspv-snapclass
source:
persistentVolumeClaimName: csi-zfspv
```
```
$ kubectl get volumesnapshot
NAME AGE
zfspv-snap 7m52s
```
```
$ kubectl get volumesnapshot -o yaml
apiVersion: v1
items:
- apiVersion: snapshot.storage.k8s.io/v1beta1
kind: VolumeSnapshot
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"snapshot.storage.k8s.io/v1beta1","kind":"VolumeSnapshot","metadata":{"annotations":{},"name":"zfspv-snap","namespace":"default"},"spec":{"source":{"persistentVolumeClaimName":"csi-zfspv"},"volumeSnapshotClassName":"zfspv-snapclass"}}
creationTimestamp: "2020-01-30T10:31:24Z"
finalizers:
- snapshot.storage.kubernetes.io/volumesnapshot-as-source-protection
- snapshot.storage.kubernetes.io/volumesnapshot-bound-protection
generation: 1
name: zfspv-snap
namespace: default
resourceVersion: "30040"
selfLink: /apis/snapshot.storage.k8s.io/v1beta1/namespaces/default/volumesnapshots/zfspv-snap
uid: 1a5cf166-c599-4f58-9f3c-f1148be47fca
spec:
source:
persistentVolumeClaimName: csi-zfspv
volumeSnapshotClassName: zfspv-snapclass
status:
boundVolumeSnapshotContentName: snapcontent-1a5cf166-c599-4f58-9f3c-f1148be47fca
creationTime: "2020-01-30T10:31:24Z"
readyToUse: true
restoreSize: "0"
kind: List
metadata:
resourceVersion: ""
selfLink: ""
```
Openebs resource for the created snapshot
```
$ kubectl get snap -n openebs -o yaml
apiVersion: v1
items:
- apiVersion: openebs.io/v1alpha1
kind: ZFSSnapshot
metadata:
creationTimestamp: "2020-01-30T10:31:24Z"
finalizers:
- zfs.openebs.io/finalizer
generation: 2
labels:
kubernetes.io/nodename: pawan-2
openebs.io/persistent-volume: pvc-18cab7c3-ec5e-4264-8507-e6f7df4c789a
name: snapshot-1a5cf166-c599-4f58-9f3c-f1148be47fca
namespace: openebs
resourceVersion: "30035"
selfLink: /apis/openebs.io/v1alpha1/namespaces/openebs/zfssnapshots/snapshot-1a5cf166-c599-4f58-9f3c-f1148be47fca
uid: e29d571c-42b5-4fb7-9110-e1cfc9b96641
spec:
capacity: "4294967296"
fsType: zfs
ownerNodeID: pawan-2
poolName: zfspv-pool
status: Ready
volumeType: DATASET
kind: List
metadata:
resourceVersion: ""
selfLink: ""
```
Create a clone volume
We can provide a datasource as snapshot name to create a clone volume
```yaml
kind: PersistentVolumeClaim
apiVersion: v1
metadata:
name: zfspv-clone
spec:
storageClassName: openebs-zfspv
dataSource:
name: zfspv-snap
kind: VolumeSnapshot
apiGroup: snapshot.storage.k8s.io
accessModes:
- ReadWriteOnce
resources:
requests:
storage: 4Gi
```
It will create a ZFS clone volume from the mentioned snapshot and create the PV on the same node where original volume is there.
Here, As resize is not supported yet, the clone PVC size should match the size of the snapshot.
Also, all the properties from the storageclass will not be considered for the clone case, it will take the properties from the snapshot and create the clone volume. One thing to note here is that, the storageclass in clone PVC should have the same poolname as that of the original volume as across the pool, clone is not supported.
Signed-off-by: Pawan <pawan@mayadata.io>
2020-02-13 13:31:17 +05:30
|
|
|
"github.com/openebs/zfs-localpv/pkg/builder/volbuilder"
|
2020-04-30 14:13:29 +05:30
|
|
|
k8sapi "github.com/openebs/zfs-localpv/pkg/client/k8s/v1alpha1"
|
2020-09-08 13:44:39 +05:30
|
|
|
"github.com/openebs/zfs-localpv/pkg/mgmt/backup"
|
|
|
|
|
"github.com/openebs/zfs-localpv/pkg/mgmt/restore"
|
feat(zfspv): adding snapshot and clone support for ZFSPV (#39)
This commits support snapshot and clone commands via CSI driver. User can create snap and clone using the following steps.
Note:
- Snapshot is created via reconciliation CR
- Cloned volume will be on the same zpool where the snapshot is taken
- Cloned volume will have same properties as source volume.
-----------------------------------
Create a Snapshotclass
```
kind: VolumeSnapshotClass
apiVersion: snapshot.storage.k8s.io/v1beta1
metadata:
name: zfspv-snapclass
annotations:
snapshot.storage.kubernetes.io/is-default-class: "true"
driver: zfs.csi.openebs.io
deletionPolicy: Delete
```
Once snapshotclass is created, we can use this class to create a Snapshot
```
apiVersion: snapshot.storage.k8s.io/v1beta1
kind: VolumeSnapshot
metadata:
name: zfspv-snap
spec:
volumeSnapshotClassName: zfspv-snapclass
source:
persistentVolumeClaimName: csi-zfspv
```
```
$ kubectl get volumesnapshot
NAME AGE
zfspv-snap 7m52s
```
```
$ kubectl get volumesnapshot -o yaml
apiVersion: v1
items:
- apiVersion: snapshot.storage.k8s.io/v1beta1
kind: VolumeSnapshot
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"snapshot.storage.k8s.io/v1beta1","kind":"VolumeSnapshot","metadata":{"annotations":{},"name":"zfspv-snap","namespace":"default"},"spec":{"source":{"persistentVolumeClaimName":"csi-zfspv"},"volumeSnapshotClassName":"zfspv-snapclass"}}
creationTimestamp: "2020-01-30T10:31:24Z"
finalizers:
- snapshot.storage.kubernetes.io/volumesnapshot-as-source-protection
- snapshot.storage.kubernetes.io/volumesnapshot-bound-protection
generation: 1
name: zfspv-snap
namespace: default
resourceVersion: "30040"
selfLink: /apis/snapshot.storage.k8s.io/v1beta1/namespaces/default/volumesnapshots/zfspv-snap
uid: 1a5cf166-c599-4f58-9f3c-f1148be47fca
spec:
source:
persistentVolumeClaimName: csi-zfspv
volumeSnapshotClassName: zfspv-snapclass
status:
boundVolumeSnapshotContentName: snapcontent-1a5cf166-c599-4f58-9f3c-f1148be47fca
creationTime: "2020-01-30T10:31:24Z"
readyToUse: true
restoreSize: "0"
kind: List
metadata:
resourceVersion: ""
selfLink: ""
```
Openebs resource for the created snapshot
```
$ kubectl get snap -n openebs -o yaml
apiVersion: v1
items:
- apiVersion: openebs.io/v1alpha1
kind: ZFSSnapshot
metadata:
creationTimestamp: "2020-01-30T10:31:24Z"
finalizers:
- zfs.openebs.io/finalizer
generation: 2
labels:
kubernetes.io/nodename: pawan-2
openebs.io/persistent-volume: pvc-18cab7c3-ec5e-4264-8507-e6f7df4c789a
name: snapshot-1a5cf166-c599-4f58-9f3c-f1148be47fca
namespace: openebs
resourceVersion: "30035"
selfLink: /apis/openebs.io/v1alpha1/namespaces/openebs/zfssnapshots/snapshot-1a5cf166-c599-4f58-9f3c-f1148be47fca
uid: e29d571c-42b5-4fb7-9110-e1cfc9b96641
spec:
capacity: "4294967296"
fsType: zfs
ownerNodeID: pawan-2
poolName: zfspv-pool
status: Ready
volumeType: DATASET
kind: List
metadata:
resourceVersion: ""
selfLink: ""
```
Create a clone volume
We can provide a datasource as snapshot name to create a clone volume
```yaml
kind: PersistentVolumeClaim
apiVersion: v1
metadata:
name: zfspv-clone
spec:
storageClassName: openebs-zfspv
dataSource:
name: zfspv-snap
kind: VolumeSnapshot
apiGroup: snapshot.storage.k8s.io
accessModes:
- ReadWriteOnce
resources:
requests:
storage: 4Gi
```
It will create a ZFS clone volume from the mentioned snapshot and create the PV on the same node where original volume is there.
Here, As resize is not supported yet, the clone PVC size should match the size of the snapshot.
Also, all the properties from the storageclass will not be considered for the clone case, it will take the properties from the snapshot and create the clone volume. One thing to note here is that, the storageclass in clone PVC should have the same poolname as that of the original volume as across the pool, clone is not supported.
Signed-off-by: Pawan <pawan@mayadata.io>
2020-02-13 13:31:17 +05:30
|
|
|
"github.com/openebs/zfs-localpv/pkg/mgmt/snapshot"
|
|
|
|
|
"github.com/openebs/zfs-localpv/pkg/mgmt/volume"
|
2020-11-25 18:49:51 +05:30
|
|
|
"github.com/openebs/zfs-localpv/pkg/mount"
|
2019-12-18 15:26:05 +05:30
|
|
|
"github.com/openebs/zfs-localpv/pkg/zfs"
|
2019-09-12 12:32:17 +05:30
|
|
|
"golang.org/x/net/context"
|
2019-12-18 15:26:05 +05:30
|
|
|
"golang.org/x/sys/unix"
|
2019-09-12 12:32:17 +05:30
|
|
|
"google.golang.org/grpc/codes"
|
|
|
|
|
"google.golang.org/grpc/status"
|
|
|
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
2020-06-29 12:18:33 +05:30
|
|
|
"k8s.io/klog"
|
feat(zfspv): adding snapshot and clone support for ZFSPV (#39)
This commits support snapshot and clone commands via CSI driver. User can create snap and clone using the following steps.
Note:
- Snapshot is created via reconciliation CR
- Cloned volume will be on the same zpool where the snapshot is taken
- Cloned volume will have same properties as source volume.
-----------------------------------
Create a Snapshotclass
```
kind: VolumeSnapshotClass
apiVersion: snapshot.storage.k8s.io/v1beta1
metadata:
name: zfspv-snapclass
annotations:
snapshot.storage.kubernetes.io/is-default-class: "true"
driver: zfs.csi.openebs.io
deletionPolicy: Delete
```
Once snapshotclass is created, we can use this class to create a Snapshot
```
apiVersion: snapshot.storage.k8s.io/v1beta1
kind: VolumeSnapshot
metadata:
name: zfspv-snap
spec:
volumeSnapshotClassName: zfspv-snapclass
source:
persistentVolumeClaimName: csi-zfspv
```
```
$ kubectl get volumesnapshot
NAME AGE
zfspv-snap 7m52s
```
```
$ kubectl get volumesnapshot -o yaml
apiVersion: v1
items:
- apiVersion: snapshot.storage.k8s.io/v1beta1
kind: VolumeSnapshot
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"snapshot.storage.k8s.io/v1beta1","kind":"VolumeSnapshot","metadata":{"annotations":{},"name":"zfspv-snap","namespace":"default"},"spec":{"source":{"persistentVolumeClaimName":"csi-zfspv"},"volumeSnapshotClassName":"zfspv-snapclass"}}
creationTimestamp: "2020-01-30T10:31:24Z"
finalizers:
- snapshot.storage.kubernetes.io/volumesnapshot-as-source-protection
- snapshot.storage.kubernetes.io/volumesnapshot-bound-protection
generation: 1
name: zfspv-snap
namespace: default
resourceVersion: "30040"
selfLink: /apis/snapshot.storage.k8s.io/v1beta1/namespaces/default/volumesnapshots/zfspv-snap
uid: 1a5cf166-c599-4f58-9f3c-f1148be47fca
spec:
source:
persistentVolumeClaimName: csi-zfspv
volumeSnapshotClassName: zfspv-snapclass
status:
boundVolumeSnapshotContentName: snapcontent-1a5cf166-c599-4f58-9f3c-f1148be47fca
creationTime: "2020-01-30T10:31:24Z"
readyToUse: true
restoreSize: "0"
kind: List
metadata:
resourceVersion: ""
selfLink: ""
```
Openebs resource for the created snapshot
```
$ kubectl get snap -n openebs -o yaml
apiVersion: v1
items:
- apiVersion: openebs.io/v1alpha1
kind: ZFSSnapshot
metadata:
creationTimestamp: "2020-01-30T10:31:24Z"
finalizers:
- zfs.openebs.io/finalizer
generation: 2
labels:
kubernetes.io/nodename: pawan-2
openebs.io/persistent-volume: pvc-18cab7c3-ec5e-4264-8507-e6f7df4c789a
name: snapshot-1a5cf166-c599-4f58-9f3c-f1148be47fca
namespace: openebs
resourceVersion: "30035"
selfLink: /apis/openebs.io/v1alpha1/namespaces/openebs/zfssnapshots/snapshot-1a5cf166-c599-4f58-9f3c-f1148be47fca
uid: e29d571c-42b5-4fb7-9110-e1cfc9b96641
spec:
capacity: "4294967296"
fsType: zfs
ownerNodeID: pawan-2
poolName: zfspv-pool
status: Ready
volumeType: DATASET
kind: List
metadata:
resourceVersion: ""
selfLink: ""
```
Create a clone volume
We can provide a datasource as snapshot name to create a clone volume
```yaml
kind: PersistentVolumeClaim
apiVersion: v1
metadata:
name: zfspv-clone
spec:
storageClassName: openebs-zfspv
dataSource:
name: zfspv-snap
kind: VolumeSnapshot
apiGroup: snapshot.storage.k8s.io
accessModes:
- ReadWriteOnce
resources:
requests:
storage: 4Gi
```
It will create a ZFS clone volume from the mentioned snapshot and create the PV on the same node where original volume is there.
Here, As resize is not supported yet, the clone PVC size should match the size of the snapshot.
Also, all the properties from the storageclass will not be considered for the clone case, it will take the properties from the snapshot and create the clone volume. One thing to note here is that, the storageclass in clone PVC should have the same poolname as that of the original volume as across the pool, clone is not supported.
Signed-off-by: Pawan <pawan@mayadata.io>
2020-02-13 13:31:17 +05:30
|
|
|
"sigs.k8s.io/controller-runtime/pkg/runtime/signals"
|
2019-09-12 12:32:17 +05:30
|
|
|
)
|
|
|
|
|
|
|
|
|
|
// node is the server implementation
|
|
|
|
|
// for CSI NodeServer
|
|
|
|
|
type node struct {
|
|
|
|
|
driver *CSIDriver
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// NewNode returns a new instance
|
|
|
|
|
// of CSI NodeServer
|
|
|
|
|
func NewNode(d *CSIDriver) csi.NodeServer {
|
|
|
|
|
var ControllerMutex = sync.RWMutex{}
|
feat(zfspv): adding snapshot and clone support for ZFSPV (#39)
This commits support snapshot and clone commands via CSI driver. User can create snap and clone using the following steps.
Note:
- Snapshot is created via reconciliation CR
- Cloned volume will be on the same zpool where the snapshot is taken
- Cloned volume will have same properties as source volume.
-----------------------------------
Create a Snapshotclass
```
kind: VolumeSnapshotClass
apiVersion: snapshot.storage.k8s.io/v1beta1
metadata:
name: zfspv-snapclass
annotations:
snapshot.storage.kubernetes.io/is-default-class: "true"
driver: zfs.csi.openebs.io
deletionPolicy: Delete
```
Once snapshotclass is created, we can use this class to create a Snapshot
```
apiVersion: snapshot.storage.k8s.io/v1beta1
kind: VolumeSnapshot
metadata:
name: zfspv-snap
spec:
volumeSnapshotClassName: zfspv-snapclass
source:
persistentVolumeClaimName: csi-zfspv
```
```
$ kubectl get volumesnapshot
NAME AGE
zfspv-snap 7m52s
```
```
$ kubectl get volumesnapshot -o yaml
apiVersion: v1
items:
- apiVersion: snapshot.storage.k8s.io/v1beta1
kind: VolumeSnapshot
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"snapshot.storage.k8s.io/v1beta1","kind":"VolumeSnapshot","metadata":{"annotations":{},"name":"zfspv-snap","namespace":"default"},"spec":{"source":{"persistentVolumeClaimName":"csi-zfspv"},"volumeSnapshotClassName":"zfspv-snapclass"}}
creationTimestamp: "2020-01-30T10:31:24Z"
finalizers:
- snapshot.storage.kubernetes.io/volumesnapshot-as-source-protection
- snapshot.storage.kubernetes.io/volumesnapshot-bound-protection
generation: 1
name: zfspv-snap
namespace: default
resourceVersion: "30040"
selfLink: /apis/snapshot.storage.k8s.io/v1beta1/namespaces/default/volumesnapshots/zfspv-snap
uid: 1a5cf166-c599-4f58-9f3c-f1148be47fca
spec:
source:
persistentVolumeClaimName: csi-zfspv
volumeSnapshotClassName: zfspv-snapclass
status:
boundVolumeSnapshotContentName: snapcontent-1a5cf166-c599-4f58-9f3c-f1148be47fca
creationTime: "2020-01-30T10:31:24Z"
readyToUse: true
restoreSize: "0"
kind: List
metadata:
resourceVersion: ""
selfLink: ""
```
Openebs resource for the created snapshot
```
$ kubectl get snap -n openebs -o yaml
apiVersion: v1
items:
- apiVersion: openebs.io/v1alpha1
kind: ZFSSnapshot
metadata:
creationTimestamp: "2020-01-30T10:31:24Z"
finalizers:
- zfs.openebs.io/finalizer
generation: 2
labels:
kubernetes.io/nodename: pawan-2
openebs.io/persistent-volume: pvc-18cab7c3-ec5e-4264-8507-e6f7df4c789a
name: snapshot-1a5cf166-c599-4f58-9f3c-f1148be47fca
namespace: openebs
resourceVersion: "30035"
selfLink: /apis/openebs.io/v1alpha1/namespaces/openebs/zfssnapshots/snapshot-1a5cf166-c599-4f58-9f3c-f1148be47fca
uid: e29d571c-42b5-4fb7-9110-e1cfc9b96641
spec:
capacity: "4294967296"
fsType: zfs
ownerNodeID: pawan-2
poolName: zfspv-pool
status: Ready
volumeType: DATASET
kind: List
metadata:
resourceVersion: ""
selfLink: ""
```
Create a clone volume
We can provide a datasource as snapshot name to create a clone volume
```yaml
kind: PersistentVolumeClaim
apiVersion: v1
metadata:
name: zfspv-clone
spec:
storageClassName: openebs-zfspv
dataSource:
name: zfspv-snap
kind: VolumeSnapshot
apiGroup: snapshot.storage.k8s.io
accessModes:
- ReadWriteOnce
resources:
requests:
storage: 4Gi
```
It will create a ZFS clone volume from the mentioned snapshot and create the PV on the same node where original volume is there.
Here, As resize is not supported yet, the clone PVC size should match the size of the snapshot.
Also, all the properties from the storageclass will not be considered for the clone case, it will take the properties from the snapshot and create the clone volume. One thing to note here is that, the storageclass in clone PVC should have the same poolname as that of the original volume as across the pool, clone is not supported.
Signed-off-by: Pawan <pawan@mayadata.io>
2020-02-13 13:31:17 +05:30
|
|
|
|
|
|
|
|
// set up signals so we handle the first shutdown signal gracefully
|
|
|
|
|
stopCh := signals.SetupSignalHandler()
|
|
|
|
|
|
2019-09-12 12:32:17 +05:30
|
|
|
// start the zfsvolume watcher
|
|
|
|
|
go func() {
|
feat(zfspv): adding snapshot and clone support for ZFSPV (#39)
This commits support snapshot and clone commands via CSI driver. User can create snap and clone using the following steps.
Note:
- Snapshot is created via reconciliation CR
- Cloned volume will be on the same zpool where the snapshot is taken
- Cloned volume will have same properties as source volume.
-----------------------------------
Create a Snapshotclass
```
kind: VolumeSnapshotClass
apiVersion: snapshot.storage.k8s.io/v1beta1
metadata:
name: zfspv-snapclass
annotations:
snapshot.storage.kubernetes.io/is-default-class: "true"
driver: zfs.csi.openebs.io
deletionPolicy: Delete
```
Once snapshotclass is created, we can use this class to create a Snapshot
```
apiVersion: snapshot.storage.k8s.io/v1beta1
kind: VolumeSnapshot
metadata:
name: zfspv-snap
spec:
volumeSnapshotClassName: zfspv-snapclass
source:
persistentVolumeClaimName: csi-zfspv
```
```
$ kubectl get volumesnapshot
NAME AGE
zfspv-snap 7m52s
```
```
$ kubectl get volumesnapshot -o yaml
apiVersion: v1
items:
- apiVersion: snapshot.storage.k8s.io/v1beta1
kind: VolumeSnapshot
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"snapshot.storage.k8s.io/v1beta1","kind":"VolumeSnapshot","metadata":{"annotations":{},"name":"zfspv-snap","namespace":"default"},"spec":{"source":{"persistentVolumeClaimName":"csi-zfspv"},"volumeSnapshotClassName":"zfspv-snapclass"}}
creationTimestamp: "2020-01-30T10:31:24Z"
finalizers:
- snapshot.storage.kubernetes.io/volumesnapshot-as-source-protection
- snapshot.storage.kubernetes.io/volumesnapshot-bound-protection
generation: 1
name: zfspv-snap
namespace: default
resourceVersion: "30040"
selfLink: /apis/snapshot.storage.k8s.io/v1beta1/namespaces/default/volumesnapshots/zfspv-snap
uid: 1a5cf166-c599-4f58-9f3c-f1148be47fca
spec:
source:
persistentVolumeClaimName: csi-zfspv
volumeSnapshotClassName: zfspv-snapclass
status:
boundVolumeSnapshotContentName: snapcontent-1a5cf166-c599-4f58-9f3c-f1148be47fca
creationTime: "2020-01-30T10:31:24Z"
readyToUse: true
restoreSize: "0"
kind: List
metadata:
resourceVersion: ""
selfLink: ""
```
Openebs resource for the created snapshot
```
$ kubectl get snap -n openebs -o yaml
apiVersion: v1
items:
- apiVersion: openebs.io/v1alpha1
kind: ZFSSnapshot
metadata:
creationTimestamp: "2020-01-30T10:31:24Z"
finalizers:
- zfs.openebs.io/finalizer
generation: 2
labels:
kubernetes.io/nodename: pawan-2
openebs.io/persistent-volume: pvc-18cab7c3-ec5e-4264-8507-e6f7df4c789a
name: snapshot-1a5cf166-c599-4f58-9f3c-f1148be47fca
namespace: openebs
resourceVersion: "30035"
selfLink: /apis/openebs.io/v1alpha1/namespaces/openebs/zfssnapshots/snapshot-1a5cf166-c599-4f58-9f3c-f1148be47fca
uid: e29d571c-42b5-4fb7-9110-e1cfc9b96641
spec:
capacity: "4294967296"
fsType: zfs
ownerNodeID: pawan-2
poolName: zfspv-pool
status: Ready
volumeType: DATASET
kind: List
metadata:
resourceVersion: ""
selfLink: ""
```
Create a clone volume
We can provide a datasource as snapshot name to create a clone volume
```yaml
kind: PersistentVolumeClaim
apiVersion: v1
metadata:
name: zfspv-clone
spec:
storageClassName: openebs-zfspv
dataSource:
name: zfspv-snap
kind: VolumeSnapshot
apiGroup: snapshot.storage.k8s.io
accessModes:
- ReadWriteOnce
resources:
requests:
storage: 4Gi
```
It will create a ZFS clone volume from the mentioned snapshot and create the PV on the same node where original volume is there.
Here, As resize is not supported yet, the clone PVC size should match the size of the snapshot.
Also, all the properties from the storageclass will not be considered for the clone case, it will take the properties from the snapshot and create the clone volume. One thing to note here is that, the storageclass in clone PVC should have the same poolname as that of the original volume as across the pool, clone is not supported.
Signed-off-by: Pawan <pawan@mayadata.io>
2020-02-13 13:31:17 +05:30
|
|
|
err := volume.Start(&ControllerMutex, stopCh)
|
2019-09-12 12:32:17 +05:30
|
|
|
if err != nil {
|
2020-06-29 12:18:33 +05:30
|
|
|
klog.Fatalf("Failed to start ZFS volume management controller: %s", err.Error())
|
2019-09-12 12:32:17 +05:30
|
|
|
}
|
|
|
|
|
}()
|
|
|
|
|
|
feat(zfspv): adding snapshot and clone support for ZFSPV (#39)
This commits support snapshot and clone commands via CSI driver. User can create snap and clone using the following steps.
Note:
- Snapshot is created via reconciliation CR
- Cloned volume will be on the same zpool where the snapshot is taken
- Cloned volume will have same properties as source volume.
-----------------------------------
Create a Snapshotclass
```
kind: VolumeSnapshotClass
apiVersion: snapshot.storage.k8s.io/v1beta1
metadata:
name: zfspv-snapclass
annotations:
snapshot.storage.kubernetes.io/is-default-class: "true"
driver: zfs.csi.openebs.io
deletionPolicy: Delete
```
Once snapshotclass is created, we can use this class to create a Snapshot
```
apiVersion: snapshot.storage.k8s.io/v1beta1
kind: VolumeSnapshot
metadata:
name: zfspv-snap
spec:
volumeSnapshotClassName: zfspv-snapclass
source:
persistentVolumeClaimName: csi-zfspv
```
```
$ kubectl get volumesnapshot
NAME AGE
zfspv-snap 7m52s
```
```
$ kubectl get volumesnapshot -o yaml
apiVersion: v1
items:
- apiVersion: snapshot.storage.k8s.io/v1beta1
kind: VolumeSnapshot
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"snapshot.storage.k8s.io/v1beta1","kind":"VolumeSnapshot","metadata":{"annotations":{},"name":"zfspv-snap","namespace":"default"},"spec":{"source":{"persistentVolumeClaimName":"csi-zfspv"},"volumeSnapshotClassName":"zfspv-snapclass"}}
creationTimestamp: "2020-01-30T10:31:24Z"
finalizers:
- snapshot.storage.kubernetes.io/volumesnapshot-as-source-protection
- snapshot.storage.kubernetes.io/volumesnapshot-bound-protection
generation: 1
name: zfspv-snap
namespace: default
resourceVersion: "30040"
selfLink: /apis/snapshot.storage.k8s.io/v1beta1/namespaces/default/volumesnapshots/zfspv-snap
uid: 1a5cf166-c599-4f58-9f3c-f1148be47fca
spec:
source:
persistentVolumeClaimName: csi-zfspv
volumeSnapshotClassName: zfspv-snapclass
status:
boundVolumeSnapshotContentName: snapcontent-1a5cf166-c599-4f58-9f3c-f1148be47fca
creationTime: "2020-01-30T10:31:24Z"
readyToUse: true
restoreSize: "0"
kind: List
metadata:
resourceVersion: ""
selfLink: ""
```
Openebs resource for the created snapshot
```
$ kubectl get snap -n openebs -o yaml
apiVersion: v1
items:
- apiVersion: openebs.io/v1alpha1
kind: ZFSSnapshot
metadata:
creationTimestamp: "2020-01-30T10:31:24Z"
finalizers:
- zfs.openebs.io/finalizer
generation: 2
labels:
kubernetes.io/nodename: pawan-2
openebs.io/persistent-volume: pvc-18cab7c3-ec5e-4264-8507-e6f7df4c789a
name: snapshot-1a5cf166-c599-4f58-9f3c-f1148be47fca
namespace: openebs
resourceVersion: "30035"
selfLink: /apis/openebs.io/v1alpha1/namespaces/openebs/zfssnapshots/snapshot-1a5cf166-c599-4f58-9f3c-f1148be47fca
uid: e29d571c-42b5-4fb7-9110-e1cfc9b96641
spec:
capacity: "4294967296"
fsType: zfs
ownerNodeID: pawan-2
poolName: zfspv-pool
status: Ready
volumeType: DATASET
kind: List
metadata:
resourceVersion: ""
selfLink: ""
```
Create a clone volume
We can provide a datasource as snapshot name to create a clone volume
```yaml
kind: PersistentVolumeClaim
apiVersion: v1
metadata:
name: zfspv-clone
spec:
storageClassName: openebs-zfspv
dataSource:
name: zfspv-snap
kind: VolumeSnapshot
apiGroup: snapshot.storage.k8s.io
accessModes:
- ReadWriteOnce
resources:
requests:
storage: 4Gi
```
It will create a ZFS clone volume from the mentioned snapshot and create the PV on the same node where original volume is there.
Here, As resize is not supported yet, the clone PVC size should match the size of the snapshot.
Also, all the properties from the storageclass will not be considered for the clone case, it will take the properties from the snapshot and create the clone volume. One thing to note here is that, the storageclass in clone PVC should have the same poolname as that of the original volume as across the pool, clone is not supported.
Signed-off-by: Pawan <pawan@mayadata.io>
2020-02-13 13:31:17 +05:30
|
|
|
// start the snapshot watcher
|
|
|
|
|
go func() {
|
|
|
|
|
err := snapshot.Start(&ControllerMutex, stopCh)
|
|
|
|
|
if err != nil {
|
2020-06-29 12:18:33 +05:30
|
|
|
klog.Fatalf("Failed to start ZFS volume snapshot management controller: %s", err.Error())
|
feat(zfspv): adding snapshot and clone support for ZFSPV (#39)
This commits support snapshot and clone commands via CSI driver. User can create snap and clone using the following steps.
Note:
- Snapshot is created via reconciliation CR
- Cloned volume will be on the same zpool where the snapshot is taken
- Cloned volume will have same properties as source volume.
-----------------------------------
Create a Snapshotclass
```
kind: VolumeSnapshotClass
apiVersion: snapshot.storage.k8s.io/v1beta1
metadata:
name: zfspv-snapclass
annotations:
snapshot.storage.kubernetes.io/is-default-class: "true"
driver: zfs.csi.openebs.io
deletionPolicy: Delete
```
Once snapshotclass is created, we can use this class to create a Snapshot
```
apiVersion: snapshot.storage.k8s.io/v1beta1
kind: VolumeSnapshot
metadata:
name: zfspv-snap
spec:
volumeSnapshotClassName: zfspv-snapclass
source:
persistentVolumeClaimName: csi-zfspv
```
```
$ kubectl get volumesnapshot
NAME AGE
zfspv-snap 7m52s
```
```
$ kubectl get volumesnapshot -o yaml
apiVersion: v1
items:
- apiVersion: snapshot.storage.k8s.io/v1beta1
kind: VolumeSnapshot
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"snapshot.storage.k8s.io/v1beta1","kind":"VolumeSnapshot","metadata":{"annotations":{},"name":"zfspv-snap","namespace":"default"},"spec":{"source":{"persistentVolumeClaimName":"csi-zfspv"},"volumeSnapshotClassName":"zfspv-snapclass"}}
creationTimestamp: "2020-01-30T10:31:24Z"
finalizers:
- snapshot.storage.kubernetes.io/volumesnapshot-as-source-protection
- snapshot.storage.kubernetes.io/volumesnapshot-bound-protection
generation: 1
name: zfspv-snap
namespace: default
resourceVersion: "30040"
selfLink: /apis/snapshot.storage.k8s.io/v1beta1/namespaces/default/volumesnapshots/zfspv-snap
uid: 1a5cf166-c599-4f58-9f3c-f1148be47fca
spec:
source:
persistentVolumeClaimName: csi-zfspv
volumeSnapshotClassName: zfspv-snapclass
status:
boundVolumeSnapshotContentName: snapcontent-1a5cf166-c599-4f58-9f3c-f1148be47fca
creationTime: "2020-01-30T10:31:24Z"
readyToUse: true
restoreSize: "0"
kind: List
metadata:
resourceVersion: ""
selfLink: ""
```
Openebs resource for the created snapshot
```
$ kubectl get snap -n openebs -o yaml
apiVersion: v1
items:
- apiVersion: openebs.io/v1alpha1
kind: ZFSSnapshot
metadata:
creationTimestamp: "2020-01-30T10:31:24Z"
finalizers:
- zfs.openebs.io/finalizer
generation: 2
labels:
kubernetes.io/nodename: pawan-2
openebs.io/persistent-volume: pvc-18cab7c3-ec5e-4264-8507-e6f7df4c789a
name: snapshot-1a5cf166-c599-4f58-9f3c-f1148be47fca
namespace: openebs
resourceVersion: "30035"
selfLink: /apis/openebs.io/v1alpha1/namespaces/openebs/zfssnapshots/snapshot-1a5cf166-c599-4f58-9f3c-f1148be47fca
uid: e29d571c-42b5-4fb7-9110-e1cfc9b96641
spec:
capacity: "4294967296"
fsType: zfs
ownerNodeID: pawan-2
poolName: zfspv-pool
status: Ready
volumeType: DATASET
kind: List
metadata:
resourceVersion: ""
selfLink: ""
```
Create a clone volume
We can provide a datasource as snapshot name to create a clone volume
```yaml
kind: PersistentVolumeClaim
apiVersion: v1
metadata:
name: zfspv-clone
spec:
storageClassName: openebs-zfspv
dataSource:
name: zfspv-snap
kind: VolumeSnapshot
apiGroup: snapshot.storage.k8s.io
accessModes:
- ReadWriteOnce
resources:
requests:
storage: 4Gi
```
It will create a ZFS clone volume from the mentioned snapshot and create the PV on the same node where original volume is there.
Here, As resize is not supported yet, the clone PVC size should match the size of the snapshot.
Also, all the properties from the storageclass will not be considered for the clone case, it will take the properties from the snapshot and create the clone volume. One thing to note here is that, the storageclass in clone PVC should have the same poolname as that of the original volume as across the pool, clone is not supported.
Signed-off-by: Pawan <pawan@mayadata.io>
2020-02-13 13:31:17 +05:30
|
|
|
}
|
|
|
|
|
}()
|
|
|
|
|
|
2020-09-08 13:44:39 +05:30
|
|
|
// start the backup controller
|
|
|
|
|
go func() {
|
|
|
|
|
err := backup.Start(&ControllerMutex, stopCh)
|
|
|
|
|
if err != nil {
|
|
|
|
|
klog.Fatalf("Failed to start ZFS backup management controller: %s", err.Error())
|
|
|
|
|
}
|
|
|
|
|
}()
|
|
|
|
|
|
|
|
|
|
// start the restore controller
|
|
|
|
|
go func() {
|
|
|
|
|
err := restore.Start(&ControllerMutex, stopCh)
|
|
|
|
|
if err != nil {
|
|
|
|
|
klog.Fatalf("Failed to start ZFS restore management controller: %s", err.Error())
|
|
|
|
|
}
|
|
|
|
|
}()
|
|
|
|
|
|
2019-09-12 12:32:17 +05:30
|
|
|
return &node{
|
|
|
|
|
driver: d,
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2020-06-09 17:17:23 +08:00
|
|
|
// GetVolAndMountInfo get volume and mount info from node csi volume request
|
2019-09-12 12:32:17 +05:30
|
|
|
func GetVolAndMountInfo(
|
|
|
|
|
req *csi.NodePublishVolumeRequest,
|
2020-10-11 22:29:23 -07:00
|
|
|
) (*apis.ZFSVolume, *zfs.MountInfo, error) {
|
|
|
|
|
var mountinfo zfs.MountInfo
|
2019-09-12 12:32:17 +05:30
|
|
|
|
|
|
|
|
mountinfo.FSType = req.GetVolumeCapability().GetMount().GetFsType()
|
|
|
|
|
mountinfo.MountPath = req.GetTargetPath()
|
|
|
|
|
mountinfo.MountOptions = append(mountinfo.MountOptions, req.GetVolumeCapability().GetMount().GetMountFlags()...)
|
|
|
|
|
|
2020-05-27 14:08:36 +05:30
|
|
|
if req.GetReadonly() {
|
|
|
|
|
mountinfo.MountOptions = append(mountinfo.MountOptions, "ro")
|
|
|
|
|
}
|
|
|
|
|
|
2020-12-10 11:53:16 +05:30
|
|
|
volName := strings.ToLower(req.GetVolumeId())
|
|
|
|
|
|
2019-09-12 12:32:17 +05:30
|
|
|
getOptions := metav1.GetOptions{}
|
feat(zfspv): adding snapshot and clone support for ZFSPV (#39)
This commits support snapshot and clone commands via CSI driver. User can create snap and clone using the following steps.
Note:
- Snapshot is created via reconciliation CR
- Cloned volume will be on the same zpool where the snapshot is taken
- Cloned volume will have same properties as source volume.
-----------------------------------
Create a Snapshotclass
```
kind: VolumeSnapshotClass
apiVersion: snapshot.storage.k8s.io/v1beta1
metadata:
name: zfspv-snapclass
annotations:
snapshot.storage.kubernetes.io/is-default-class: "true"
driver: zfs.csi.openebs.io
deletionPolicy: Delete
```
Once snapshotclass is created, we can use this class to create a Snapshot
```
apiVersion: snapshot.storage.k8s.io/v1beta1
kind: VolumeSnapshot
metadata:
name: zfspv-snap
spec:
volumeSnapshotClassName: zfspv-snapclass
source:
persistentVolumeClaimName: csi-zfspv
```
```
$ kubectl get volumesnapshot
NAME AGE
zfspv-snap 7m52s
```
```
$ kubectl get volumesnapshot -o yaml
apiVersion: v1
items:
- apiVersion: snapshot.storage.k8s.io/v1beta1
kind: VolumeSnapshot
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"snapshot.storage.k8s.io/v1beta1","kind":"VolumeSnapshot","metadata":{"annotations":{},"name":"zfspv-snap","namespace":"default"},"spec":{"source":{"persistentVolumeClaimName":"csi-zfspv"},"volumeSnapshotClassName":"zfspv-snapclass"}}
creationTimestamp: "2020-01-30T10:31:24Z"
finalizers:
- snapshot.storage.kubernetes.io/volumesnapshot-as-source-protection
- snapshot.storage.kubernetes.io/volumesnapshot-bound-protection
generation: 1
name: zfspv-snap
namespace: default
resourceVersion: "30040"
selfLink: /apis/snapshot.storage.k8s.io/v1beta1/namespaces/default/volumesnapshots/zfspv-snap
uid: 1a5cf166-c599-4f58-9f3c-f1148be47fca
spec:
source:
persistentVolumeClaimName: csi-zfspv
volumeSnapshotClassName: zfspv-snapclass
status:
boundVolumeSnapshotContentName: snapcontent-1a5cf166-c599-4f58-9f3c-f1148be47fca
creationTime: "2020-01-30T10:31:24Z"
readyToUse: true
restoreSize: "0"
kind: List
metadata:
resourceVersion: ""
selfLink: ""
```
Openebs resource for the created snapshot
```
$ kubectl get snap -n openebs -o yaml
apiVersion: v1
items:
- apiVersion: openebs.io/v1alpha1
kind: ZFSSnapshot
metadata:
creationTimestamp: "2020-01-30T10:31:24Z"
finalizers:
- zfs.openebs.io/finalizer
generation: 2
labels:
kubernetes.io/nodename: pawan-2
openebs.io/persistent-volume: pvc-18cab7c3-ec5e-4264-8507-e6f7df4c789a
name: snapshot-1a5cf166-c599-4f58-9f3c-f1148be47fca
namespace: openebs
resourceVersion: "30035"
selfLink: /apis/openebs.io/v1alpha1/namespaces/openebs/zfssnapshots/snapshot-1a5cf166-c599-4f58-9f3c-f1148be47fca
uid: e29d571c-42b5-4fb7-9110-e1cfc9b96641
spec:
capacity: "4294967296"
fsType: zfs
ownerNodeID: pawan-2
poolName: zfspv-pool
status: Ready
volumeType: DATASET
kind: List
metadata:
resourceVersion: ""
selfLink: ""
```
Create a clone volume
We can provide a datasource as snapshot name to create a clone volume
```yaml
kind: PersistentVolumeClaim
apiVersion: v1
metadata:
name: zfspv-clone
spec:
storageClassName: openebs-zfspv
dataSource:
name: zfspv-snap
kind: VolumeSnapshot
apiGroup: snapshot.storage.k8s.io
accessModes:
- ReadWriteOnce
resources:
requests:
storage: 4Gi
```
It will create a ZFS clone volume from the mentioned snapshot and create the PV on the same node where original volume is there.
Here, As resize is not supported yet, the clone PVC size should match the size of the snapshot.
Also, all the properties from the storageclass will not be considered for the clone case, it will take the properties from the snapshot and create the clone volume. One thing to note here is that, the storageclass in clone PVC should have the same poolname as that of the original volume as across the pool, clone is not supported.
Signed-off-by: Pawan <pawan@mayadata.io>
2020-02-13 13:31:17 +05:30
|
|
|
vol, err := volbuilder.NewKubeclient().
|
2019-11-21 19:00:15 +05:30
|
|
|
WithNamespace(zfs.OpenEBSNamespace).
|
2020-12-10 11:53:16 +05:30
|
|
|
Get(volName, getOptions)
|
2019-09-12 12:32:17 +05:30
|
|
|
|
|
|
|
|
if err != nil {
|
|
|
|
|
return nil, nil, err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return vol, &mountinfo, nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// NodePublishVolume publishes (mounts) the volume
|
|
|
|
|
// at the corresponding node at a given path
|
|
|
|
|
//
|
|
|
|
|
// This implements csi.NodeServer
|
|
|
|
|
func (ns *node) NodePublishVolume(
|
|
|
|
|
ctx context.Context,
|
|
|
|
|
req *csi.NodePublishVolumeRequest,
|
|
|
|
|
) (*csi.NodePublishVolumeResponse, error) {
|
|
|
|
|
|
|
|
|
|
var (
|
|
|
|
|
err error
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
if err = ns.validateNodePublishReq(req); err != nil {
|
|
|
|
|
return nil, err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
vol, mountInfo, err := GetVolAndMountInfo(req)
|
|
|
|
|
if err != nil {
|
2020-05-05 12:28:46 +05:30
|
|
|
return nil, status.Error(codes.Internal, err.Error())
|
2019-09-12 12:32:17 +05:30
|
|
|
}
|
2020-05-05 12:28:46 +05:30
|
|
|
// If the access type is block, do nothing for stage
|
|
|
|
|
switch req.GetVolumeCapability().GetAccessType().(type) {
|
|
|
|
|
case *csi.VolumeCapability_Block:
|
|
|
|
|
// attempt block mount operation on the requested path
|
|
|
|
|
err = zfs.MountBlock(vol, mountInfo)
|
|
|
|
|
case *csi.VolumeCapability_Mount:
|
|
|
|
|
// attempt filesystem mount operation on the requested path
|
|
|
|
|
err = zfs.MountFilesystem(vol, mountInfo)
|
2019-09-12 12:32:17 +05:30
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if err != nil {
|
|
|
|
|
return nil, status.Error(codes.Internal, err.Error())
|
|
|
|
|
}
|
|
|
|
|
return &csi.NodePublishVolumeResponse{}, nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// NodeUnpublishVolume unpublishes (unmounts) the volume
|
|
|
|
|
// from the corresponding node from the given path
|
|
|
|
|
//
|
|
|
|
|
// This implements csi.NodeServer
|
|
|
|
|
func (ns *node) NodeUnpublishVolume(
|
|
|
|
|
ctx context.Context,
|
|
|
|
|
req *csi.NodeUnpublishVolumeRequest,
|
|
|
|
|
) (*csi.NodeUnpublishVolumeResponse, error) {
|
|
|
|
|
|
|
|
|
|
var (
|
feat(zfspv): handling unmounted volume
There can be cases where openebs namespace has been accidently deleted (Optoro case: https://mdap.zendesk.com/agent/tickets/963), There the driver attempted to destroy the dataset which will first umount the dataset and then try to destroy it, the destroy will fail as volume is busy. Here, as mentioned in the steps to recover, we have to manually mount the dataset
```
6. The driver might have attempted to destroy the volume before going down, which sets the mount as no(this strange behavior on gke ubuntu 18.04), we have to mount the dataset, go to the each node and check if there is any unmounted volume
zfs get mounted
if there is any unmounted dataset with this option as "no", we should do the below :-
mountpath=zfs get -Hp -o value mountpoint <dataset name>
zfs set mountpoint=none
zfs set mountpoint=<mountpath>
this will set the dataset to be mounted.
```
So in this case the volume will be unmounted and still mountpoint will set to the mountpath, so if application pod is deleted later on, it will try to mount the zfs dataset, here just setting the `mountpoint` is not sufficient, as if we have unmounted the zfs dataset (via zfs destroy in this case), so we have to explicitely mount the dataset **otherwise application will start running without any persistence storage**. Here automating the manual steps performed to resolve the problem, we are checking in the code that if zfs dataset is not mounted after setting the mountpoint property, attempt to mount it.
This is not the case with the zvol as it does not attempt to unmount it, so zvols are fine.
Also NodeUnPublish operation MUST be idempotent. If this RPC failed, or the CO does not know if it failed or not, it can choose to call NudeUnPublishRequest again. So handled this and returned successful if volume is not mounted also added descriptive error messages at few places.
Signed-off-by: Pawan <pawan@mayadata.io>
2020-04-06 20:09:07 +05:30
|
|
|
err error
|
|
|
|
|
vol *apis.ZFSVolume
|
2019-09-12 12:32:17 +05:30
|
|
|
)
|
|
|
|
|
|
|
|
|
|
if err = ns.validateNodeUnpublishReq(req); err != nil {
|
|
|
|
|
return nil, err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
targetPath := req.GetTargetPath()
|
|
|
|
|
volumeID := req.GetVolumeId()
|
|
|
|
|
|
2019-11-21 19:00:15 +05:30
|
|
|
if vol, err = zfs.GetZFSVolume(volumeID); err != nil {
|
feat(zfspv): handling unmounted volume
There can be cases where openebs namespace has been accidently deleted (Optoro case: https://mdap.zendesk.com/agent/tickets/963), There the driver attempted to destroy the dataset which will first umount the dataset and then try to destroy it, the destroy will fail as volume is busy. Here, as mentioned in the steps to recover, we have to manually mount the dataset
```
6. The driver might have attempted to destroy the volume before going down, which sets the mount as no(this strange behavior on gke ubuntu 18.04), we have to mount the dataset, go to the each node and check if there is any unmounted volume
zfs get mounted
if there is any unmounted dataset with this option as "no", we should do the below :-
mountpath=zfs get -Hp -o value mountpoint <dataset name>
zfs set mountpoint=none
zfs set mountpoint=<mountpath>
this will set the dataset to be mounted.
```
So in this case the volume will be unmounted and still mountpoint will set to the mountpath, so if application pod is deleted later on, it will try to mount the zfs dataset, here just setting the `mountpoint` is not sufficient, as if we have unmounted the zfs dataset (via zfs destroy in this case), so we have to explicitely mount the dataset **otherwise application will start running without any persistence storage**. Here automating the manual steps performed to resolve the problem, we are checking in the code that if zfs dataset is not mounted after setting the mountpoint property, attempt to mount it.
This is not the case with the zvol as it does not attempt to unmount it, so zvols are fine.
Also NodeUnPublish operation MUST be idempotent. If this RPC failed, or the CO does not know if it failed or not, it can choose to call NudeUnPublishRequest again. So handled this and returned successful if volume is not mounted also added descriptive error messages at few places.
Signed-off-by: Pawan <pawan@mayadata.io>
2020-04-06 20:09:07 +05:30
|
|
|
return nil, status.Errorf(codes.Internal,
|
|
|
|
|
"not able to get the ZFSVolume %s err : %s",
|
|
|
|
|
volumeID, err.Error())
|
2019-09-12 12:32:17 +05:30
|
|
|
}
|
|
|
|
|
|
feat(zfspv): handling unmounted volume
There can be cases where openebs namespace has been accidently deleted (Optoro case: https://mdap.zendesk.com/agent/tickets/963), There the driver attempted to destroy the dataset which will first umount the dataset and then try to destroy it, the destroy will fail as volume is busy. Here, as mentioned in the steps to recover, we have to manually mount the dataset
```
6. The driver might have attempted to destroy the volume before going down, which sets the mount as no(this strange behavior on gke ubuntu 18.04), we have to mount the dataset, go to the each node and check if there is any unmounted volume
zfs get mounted
if there is any unmounted dataset with this option as "no", we should do the below :-
mountpath=zfs get -Hp -o value mountpoint <dataset name>
zfs set mountpoint=none
zfs set mountpoint=<mountpath>
this will set the dataset to be mounted.
```
So in this case the volume will be unmounted and still mountpoint will set to the mountpath, so if application pod is deleted later on, it will try to mount the zfs dataset, here just setting the `mountpoint` is not sufficient, as if we have unmounted the zfs dataset (via zfs destroy in this case), so we have to explicitely mount the dataset **otherwise application will start running without any persistence storage**. Here automating the manual steps performed to resolve the problem, we are checking in the code that if zfs dataset is not mounted after setting the mountpoint property, attempt to mount it.
This is not the case with the zvol as it does not attempt to unmount it, so zvols are fine.
Also NodeUnPublish operation MUST be idempotent. If this RPC failed, or the CO does not know if it failed or not, it can choose to call NudeUnPublishRequest again. So handled this and returned successful if volume is not mounted also added descriptive error messages at few places.
Signed-off-by: Pawan <pawan@mayadata.io>
2020-04-06 20:09:07 +05:30
|
|
|
err = zfs.UmountVolume(vol, targetPath)
|
2019-11-21 19:00:15 +05:30
|
|
|
|
2019-09-12 12:32:17 +05:30
|
|
|
if err != nil {
|
feat(zfspv): handling unmounted volume
There can be cases where openebs namespace has been accidently deleted (Optoro case: https://mdap.zendesk.com/agent/tickets/963), There the driver attempted to destroy the dataset which will first umount the dataset and then try to destroy it, the destroy will fail as volume is busy. Here, as mentioned in the steps to recover, we have to manually mount the dataset
```
6. The driver might have attempted to destroy the volume before going down, which sets the mount as no(this strange behavior on gke ubuntu 18.04), we have to mount the dataset, go to the each node and check if there is any unmounted volume
zfs get mounted
if there is any unmounted dataset with this option as "no", we should do the below :-
mountpath=zfs get -Hp -o value mountpoint <dataset name>
zfs set mountpoint=none
zfs set mountpoint=<mountpath>
this will set the dataset to be mounted.
```
So in this case the volume will be unmounted and still mountpoint will set to the mountpath, so if application pod is deleted later on, it will try to mount the zfs dataset, here just setting the `mountpoint` is not sufficient, as if we have unmounted the zfs dataset (via zfs destroy in this case), so we have to explicitely mount the dataset **otherwise application will start running without any persistence storage**. Here automating the manual steps performed to resolve the problem, we are checking in the code that if zfs dataset is not mounted after setting the mountpoint property, attempt to mount it.
This is not the case with the zvol as it does not attempt to unmount it, so zvols are fine.
Also NodeUnPublish operation MUST be idempotent. If this RPC failed, or the CO does not know if it failed or not, it can choose to call NudeUnPublishRequest again. So handled this and returned successful if volume is not mounted also added descriptive error messages at few places.
Signed-off-by: Pawan <pawan@mayadata.io>
2020-04-06 20:09:07 +05:30
|
|
|
return nil, status.Errorf(codes.Internal,
|
|
|
|
|
"unable to umount the volume %s err : %s",
|
|
|
|
|
volumeID, err.Error())
|
2019-11-21 19:00:15 +05:30
|
|
|
}
|
2020-06-29 12:18:33 +05:30
|
|
|
klog.Infof("hostpath: volume %s path: %s has been unmounted.",
|
2019-09-12 12:32:17 +05:30
|
|
|
volumeID, targetPath)
|
|
|
|
|
|
|
|
|
|
return &csi.NodeUnpublishVolumeResponse{}, nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// NodeGetInfo returns node details
|
|
|
|
|
//
|
|
|
|
|
// This implements csi.NodeServer
|
|
|
|
|
func (ns *node) NodeGetInfo(
|
|
|
|
|
ctx context.Context,
|
|
|
|
|
req *csi.NodeGetInfoRequest,
|
|
|
|
|
) (*csi.NodeGetInfoResponse, error) {
|
|
|
|
|
|
2020-04-30 14:13:29 +05:30
|
|
|
node, err := k8sapi.GetNode(ns.driver.config.NodeID)
|
|
|
|
|
if err != nil {
|
2020-06-29 12:18:33 +05:30
|
|
|
klog.Errorf("failed to get the node %s", ns.driver.config.NodeID)
|
2020-04-30 14:13:29 +05:30
|
|
|
return nil, err
|
|
|
|
|
}
|
|
|
|
|
/*
|
|
|
|
|
* The driver will support all the keys and values defined in the node's label.
|
|
|
|
|
* if nodes are labeled with the below keys and values
|
|
|
|
|
* map[beta.kubernetes.io/arch:amd64 beta.kubernetes.io/os:linux kubernetes.io/arch:amd64 kubernetes.io/hostname:pawan-node-1 kubernetes.io/os:linux node-role.kubernetes.io/worker:true openebs.io/zone:zone1 openebs.io/zpool:ssd]
|
|
|
|
|
* The driver will support below key and values
|
|
|
|
|
* {
|
|
|
|
|
* beta.kubernetes.io/arch:amd64
|
|
|
|
|
* beta.kubernetes.io/os:linux
|
|
|
|
|
* kubernetes.io/arch:amd64
|
|
|
|
|
* kubernetes.io/hostname:pawan-node-1
|
|
|
|
|
* kubernetes.io/os:linux
|
|
|
|
|
* node-role.kubernetes.io/worker:true
|
|
|
|
|
* openebs.io/zone:zone1
|
|
|
|
|
* openebs.io/zpool:ssd
|
|
|
|
|
* }
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
// support all the keys that node has
|
|
|
|
|
topology := node.Labels
|
|
|
|
|
|
|
|
|
|
// add driver's topology key
|
|
|
|
|
topology[zfs.ZFSTopologyKey] = ns.driver.config.NodeID
|
|
|
|
|
|
2019-09-12 12:32:17 +05:30
|
|
|
return &csi.NodeGetInfoResponse{
|
|
|
|
|
NodeId: ns.driver.config.NodeID,
|
2019-11-01 06:46:04 +05:30
|
|
|
AccessibleTopology: &csi.Topology{
|
|
|
|
|
Segments: topology,
|
|
|
|
|
},
|
2019-09-12 12:32:17 +05:30
|
|
|
}, nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// NodeGetCapabilities returns capabilities supported
|
|
|
|
|
// by this node service
|
|
|
|
|
//
|
|
|
|
|
// This implements csi.NodeServer
|
|
|
|
|
func (ns *node) NodeGetCapabilities(
|
|
|
|
|
ctx context.Context,
|
|
|
|
|
req *csi.NodeGetCapabilitiesRequest,
|
|
|
|
|
) (*csi.NodeGetCapabilitiesResponse, error) {
|
|
|
|
|
|
|
|
|
|
return &csi.NodeGetCapabilitiesResponse{
|
|
|
|
|
Capabilities: []*csi.NodeServiceCapability{
|
|
|
|
|
{
|
|
|
|
|
Type: &csi.NodeServiceCapability_Rpc{
|
|
|
|
|
Rpc: &csi.NodeServiceCapability_RPC{
|
2019-12-18 15:26:05 +05:30
|
|
|
Type: csi.NodeServiceCapability_RPC_GET_VOLUME_STATS,
|
2019-09-12 12:32:17 +05:30
|
|
|
},
|
|
|
|
|
},
|
|
|
|
|
},
|
2020-03-02 12:03:03 +05:30
|
|
|
{
|
|
|
|
|
Type: &csi.NodeServiceCapability_Rpc{
|
|
|
|
|
Rpc: &csi.NodeServiceCapability_RPC{
|
|
|
|
|
Type: csi.NodeServiceCapability_RPC_EXPAND_VOLUME,
|
|
|
|
|
},
|
|
|
|
|
},
|
|
|
|
|
},
|
2019-09-12 12:32:17 +05:30
|
|
|
},
|
|
|
|
|
}, nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// TODO
|
|
|
|
|
// This needs to be implemented
|
|
|
|
|
//
|
|
|
|
|
// NodeStageVolume mounts the volume on the staging
|
|
|
|
|
// path
|
|
|
|
|
//
|
|
|
|
|
// This implements csi.NodeServer
|
|
|
|
|
func (ns *node) NodeStageVolume(
|
|
|
|
|
ctx context.Context,
|
|
|
|
|
req *csi.NodeStageVolumeRequest,
|
|
|
|
|
) (*csi.NodeStageVolumeResponse, error) {
|
|
|
|
|
|
2020-12-10 11:53:16 +05:30
|
|
|
return nil, status.Error(codes.Unimplemented, "")
|
2019-09-12 12:32:17 +05:30
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// NodeUnstageVolume unmounts the volume from
|
|
|
|
|
// the staging path
|
|
|
|
|
//
|
|
|
|
|
// This implements csi.NodeServer
|
|
|
|
|
func (ns *node) NodeUnstageVolume(
|
|
|
|
|
ctx context.Context,
|
|
|
|
|
req *csi.NodeUnstageVolumeRequest,
|
|
|
|
|
) (*csi.NodeUnstageVolumeResponse, error) {
|
|
|
|
|
|
2020-12-10 11:53:16 +05:30
|
|
|
return nil, status.Error(codes.Unimplemented, "")
|
2019-09-12 12:32:17 +05:30
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// TODO
|
|
|
|
|
// Verify if this needs to be implemented
|
|
|
|
|
//
|
|
|
|
|
// NodeExpandVolume resizes the filesystem if required
|
|
|
|
|
//
|
|
|
|
|
// If ControllerExpandVolumeResponse returns true in
|
|
|
|
|
// node_expansion_required then FileSystemResizePending
|
|
|
|
|
// condition will be added to PVC and NodeExpandVolume
|
|
|
|
|
// operation will be queued on kubelet
|
|
|
|
|
//
|
|
|
|
|
// This implements csi.NodeServer
|
|
|
|
|
func (ns *node) NodeExpandVolume(
|
|
|
|
|
ctx context.Context,
|
|
|
|
|
req *csi.NodeExpandVolumeRequest,
|
|
|
|
|
) (*csi.NodeExpandVolumeResponse, error) {
|
|
|
|
|
|
2020-03-02 12:03:03 +05:30
|
|
|
volumeID := req.GetVolumeId()
|
2020-12-10 11:53:16 +05:30
|
|
|
if req.GetVolumePath() == "" || volumeID == "" {
|
|
|
|
|
return nil, status.Errorf(
|
|
|
|
|
codes.InvalidArgument,
|
|
|
|
|
"path not provided for NodeExpandVolume Request %s",
|
|
|
|
|
volumeID,
|
|
|
|
|
)
|
|
|
|
|
}
|
|
|
|
|
|
2020-03-02 12:03:03 +05:30
|
|
|
vol, err := zfs.GetZFSVolume(volumeID)
|
|
|
|
|
|
|
|
|
|
if err != nil {
|
|
|
|
|
return nil, status.Errorf(
|
2020-12-10 11:53:16 +05:30
|
|
|
codes.NotFound,
|
2020-03-02 12:03:03 +05:30
|
|
|
"failed to handle NodeExpandVolume Request for %s, {%s}",
|
|
|
|
|
req.VolumeId,
|
|
|
|
|
err.Error(),
|
|
|
|
|
)
|
|
|
|
|
}
|
|
|
|
|
if err = zfs.ResizeZFSVolume(vol, req.GetVolumePath()); err != nil {
|
|
|
|
|
return nil, status.Errorf(
|
|
|
|
|
codes.Internal,
|
|
|
|
|
"failed to handle NodeExpandVolume Request for %s, {%s}",
|
|
|
|
|
req.VolumeId,
|
|
|
|
|
err.Error(),
|
|
|
|
|
)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return &csi.NodeExpandVolumeResponse{
|
|
|
|
|
CapacityBytes: req.GetCapacityRange().GetRequiredBytes(),
|
|
|
|
|
}, nil
|
2019-09-12 12:32:17 +05:30
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// NodeGetVolumeStats returns statistics for the
|
|
|
|
|
// given volume
|
|
|
|
|
func (ns *node) NodeGetVolumeStats(
|
|
|
|
|
ctx context.Context,
|
2019-12-18 15:26:05 +05:30
|
|
|
req *csi.NodeGetVolumeStatsRequest,
|
2019-09-12 12:32:17 +05:30
|
|
|
) (*csi.NodeGetVolumeStatsResponse, error) {
|
|
|
|
|
|
2019-12-18 15:26:05 +05:30
|
|
|
volID := req.GetVolumeId()
|
|
|
|
|
path := req.GetVolumePath()
|
|
|
|
|
|
|
|
|
|
if len(volID) == 0 {
|
|
|
|
|
return nil, status.Error(codes.InvalidArgument, "volume id is not provided")
|
|
|
|
|
}
|
|
|
|
|
if len(path) == 0 {
|
|
|
|
|
return nil, status.Error(codes.InvalidArgument, "path is not provided")
|
|
|
|
|
}
|
|
|
|
|
|
2020-11-25 18:49:51 +05:30
|
|
|
if mount.IsMountPath(path) == false {
|
2020-12-10 11:53:16 +05:30
|
|
|
return nil, status.Error(codes.NotFound, "path is not a mount path")
|
2019-12-19 16:03:35 +05:30
|
|
|
}
|
|
|
|
|
|
2019-12-18 15:26:05 +05:30
|
|
|
var sfs unix.Statfs_t
|
|
|
|
|
if err := unix.Statfs(path, &sfs); err != nil {
|
2019-12-19 16:03:35 +05:30
|
|
|
return nil, status.Errorf(codes.Internal, "statfs on %s failed: %v", path, err)
|
2019-12-18 15:26:05 +05:30
|
|
|
}
|
|
|
|
|
|
|
|
|
|
var usage []*csi.VolumeUsage
|
|
|
|
|
usage = append(usage, &csi.VolumeUsage{
|
|
|
|
|
Unit: csi.VolumeUsage_BYTES,
|
|
|
|
|
Total: int64(sfs.Blocks) * sfs.Bsize,
|
|
|
|
|
Used: int64(sfs.Blocks-sfs.Bfree) * sfs.Bsize,
|
|
|
|
|
Available: int64(sfs.Bavail) * sfs.Bsize,
|
|
|
|
|
})
|
|
|
|
|
usage = append(usage, &csi.VolumeUsage{
|
|
|
|
|
Unit: csi.VolumeUsage_INODES,
|
|
|
|
|
Total: int64(sfs.Files),
|
|
|
|
|
Used: int64(sfs.Files - sfs.Ffree),
|
|
|
|
|
Available: int64(sfs.Ffree),
|
|
|
|
|
})
|
|
|
|
|
|
|
|
|
|
return &csi.NodeGetVolumeStatsResponse{Usage: usage}, nil
|
2019-09-12 12:32:17 +05:30
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (ns *node) validateNodePublishReq(
|
|
|
|
|
req *csi.NodePublishVolumeRequest,
|
|
|
|
|
) error {
|
|
|
|
|
if req.GetVolumeCapability() == nil {
|
|
|
|
|
return status.Error(codes.InvalidArgument,
|
|
|
|
|
"Volume capability missing in request")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if len(req.GetVolumeId()) == 0 {
|
|
|
|
|
return status.Error(codes.InvalidArgument,
|
|
|
|
|
"Volume ID missing in request")
|
|
|
|
|
}
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (ns *node) validateNodeUnpublishReq(
|
|
|
|
|
req *csi.NodeUnpublishVolumeRequest,
|
|
|
|
|
) error {
|
|
|
|
|
if req.GetVolumeId() == "" {
|
|
|
|
|
return status.Error(codes.InvalidArgument,
|
|
|
|
|
"Volume ID missing in request")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if req.GetTargetPath() == "" {
|
|
|
|
|
return status.Error(codes.InvalidArgument,
|
|
|
|
|
"Target path missing in request")
|
|
|
|
|
}
|
|
|
|
|
return nil
|
|
|
|
|
}
|