improv: small details

This commit is contained in:
iff 2023-07-31 03:21:06 +02:00
parent 982149802a
commit 72db07051b
5 changed files with 26 additions and 20 deletions

View file

@ -1,4 +1,4 @@
command = "sudo" command = "privilege"
[[match_output]] [[match_output]]
pattern = [ pattern = [

View file

@ -2,20 +2,20 @@ use std::collections::HashMap;
use rule_parser::parse_rules; use rule_parser::parse_rules;
use crate::shell::command_output; use crate::shell::{command_output, PRIVILEGE_LIST};
use crate::style::highlight_difference; use crate::style::highlight_difference;
pub fn correct_command(shell: &str, last_command: &str) -> Option<String> { pub fn correct_command(shell: &str, last_command: &str) -> Option<String> {
let command_output = command_output(shell, last_command); let command_output = command_output(shell, last_command);
let split_command = last_command.split_whitespace().collect::<Vec<&str>>(); let split_command = last_command.split_whitespace().collect::<Vec<&str>>();
let command = match split_command.first().expect("No command found.") { let command = match PRIVILEGE_LIST.contains(&split_command[0]) {
&"sudo" => split_command.get(1).expect("No command found."), true => split_command.get(1).expect("No command found."),
_ => split_command.first().expect("No command found."), false => split_command.first().expect("No command found."),
}; };
if split_command[0] != "sudo" { if !PRIVILEGE_LIST.contains(command) {
let suggest = match_pattern("sudo", &command_output); let suggest = match_pattern("privilege", &command_output);
if let Some(suggest) = suggest { if let Some(suggest) = suggest {
let suggest = eval_suggest(&suggest, last_command); let suggest = eval_suggest(&suggest, last_command);
return Some(suggest); return Some(suggest);
@ -24,8 +24,8 @@ pub fn correct_command(shell: &str, last_command: &str) -> Option<String> {
let suggest = match_pattern(command, &command_output); let suggest = match_pattern(command, &command_output);
if let Some(suggest) = suggest { if let Some(suggest) = suggest {
let suggest = eval_suggest(&suggest, last_command); let suggest = eval_suggest(&suggest, last_command);
if split_command[0] == "sudo" { if PRIVILEGE_LIST.contains(command) {
return Some(format!("sudo {}", suggest)); return Some(format!("{} {}", split_command[0], suggest));
} }
return Some(suggest); return Some(suggest);
} }
@ -92,12 +92,11 @@ pub fn confirm_correction(shell: &str, command: &str, last_command: &str) {
println!("Press enter to execute the corrected command. Or press Ctrl+C to exit."); println!("Press enter to execute the corrected command. Or press Ctrl+C to exit.");
std::io::stdin().read_line(&mut String::new()).unwrap(); std::io::stdin().read_line(&mut String::new()).unwrap();
let privilege = Vec::from(["doas", "sudo"]); for p in PRIVILEGE_LIST {
if command.starts_with(p) {
for p in privilege {
if command.starts_with(p){
let command = command.replace(p, ""); let command = command.replace(p, "");
std::process::Command::new(p) println!("{} {}", p, command);
std::process::Command::new(p.trim())
.arg(shell) .arg(shell)
.arg("-c") .arg("-c")
.arg(command) .arg(command)

View file

@ -12,7 +12,7 @@ fn main() {
let corrected_command = corrections::correct_command(&shell, &last_command); let corrected_command = corrections::correct_command(&shell, &last_command);
if let Some(mut corrected_command) = corrected_command { if let Some(mut corrected_command) = corrected_command {
if corrected_command.starts_with("sudo") { if corrected_command.starts_with("sudo ") {
let privilege = get_privilege(); let privilege = get_privilege();
if let Some(privilege) = privilege { if let Some(privilege) = privilege {
if privilege != "sudo" { if privilege != "sudo" {
@ -22,6 +22,11 @@ fn main() {
} }
corrections::confirm_correction(&shell, &corrected_command, &last_command); corrections::confirm_correction(&shell, &corrected_command, &last_command);
} else { } else {
println!("No correction found."); println!(
"
No correction found.
If you think there should be a correction, please open an issue or send a pull request!"
);
} }
} }

View file

@ -1,5 +1,7 @@
use std::{collections::HashMap, fs::read_to_string, process::exit}; use std::{collections::HashMap, fs::read_to_string, process::exit};
pub const PRIVILEGE_LIST: [&str; 2] = ["doas ", "sudo "];
pub fn find_shell() -> String { pub fn find_shell() -> String {
std::env::var("SHELL") std::env::var("SHELL")
.unwrap_or_else(|_| String::from("bash")) .unwrap_or_else(|_| String::from("bash"))
@ -17,7 +19,8 @@ pub fn find_last_command(shell: &str) -> String {
Err(_) => shell_default_history_file(shell), Err(_) => shell_default_history_file(shell),
}; };
let history = read_to_string(history_file).expect("Could not read history file."); let history = read_to_string(history_file)
.expect("Could not read history file. Try setting the HISTFILE environment variable.");
match shell { match shell {
"bash" => history.lines().rev().nth(1).unwrap().to_string(), "bash" => history.lines().rev().nth(1).unwrap().to_string(),
@ -73,8 +76,8 @@ fn shell_default_history_file(shell: &str) -> String {
} }
pub fn get_privilege() -> Option<String> { pub fn get_privilege() -> Option<String> {
let list = vec!["doas", "sudo"]; for command in PRIVILEGE_LIST {
for command in list { let command = command.trim();
if std::process::Command::new(command).output().is_ok() { if std::process::Command::new(command).output().is_ok() {
return Some(command.to_string()); return Some(command.to_string());
} }

View file

@ -1,4 +1,3 @@
use colored::*; use colored::*;
pub fn highlight_difference(corrected_command: &str, last_command: &str) -> String { pub fn highlight_difference(corrected_command: &str, last_command: &str) -> String {