From d0e47e305dc637ea4cf0565dfab3cc115d597377 Mon Sep 17 00:00:00 2001 From: technofab Date: Sun, 11 May 2025 17:46:13 +0200 Subject: [PATCH] fix: handle error instead of including it in diff --- cmd/nixtest/junit.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cmd/nixtest/junit.go b/cmd/nixtest/junit.go index e79b3b3..dc6b6e5 100644 --- a/cmd/nixtest/junit.go +++ b/cmd/nixtest/junit.go @@ -90,7 +90,10 @@ func GenerateJUnitReport(name string, results Results) (string, error) { report.Failures++ // FIXME: ComputeEdits deprecated edits := myers.ComputeEdits(result.Expected, result.Actual) - diff := fmt.Sprint(textdiff.ToUnified("expected", "actual", result.Expected, edits, 3)) + diff, err := textdiff.ToUnified("expected", "actual", result.Expected, edits, 3) + if err != nil { + return "", err + } // remove newline hint diff = strings.ReplaceAll(diff, "\\ No newline at end of file\n", "") testCase.Failure = &diff