fix(jobPatched) Fixed some attributes not being passed into ci

Fixed modifying continuous integration settings attributes only when the job is configured via nix,
plus improved tests for this functionality.
This commit is contained in:
Skryta Istota 2025-11-30 12:55:22 +01:00
parent d2f8a70675
commit 0f9d0aae60
No known key found for this signature in database
2 changed files with 29 additions and 33 deletions

View file

@ -11,13 +11,11 @@ in
pipelineName,
nixConfig,
}:
(builtins.removeAttrs job ["variables" "cache"])
// (optionalAttrs nixConfig.enable (
(prependToBeforeScript ["source setup_nix_ci \"gitlab-ci:pipeline:${pipelineName}:job-deps:${key}\""] job)
// (appendToAfterScript ["finalize_nix_ci"] job)
))
// optionalAttrs nixConfig.enable (
(let
if ! nixConfig.enable then job else
(builtins.removeAttrs job [ "variables" "cache" ])
// (prependToBeforeScript [ "source setup_nix_ci \"gitlab-ci:pipeline:${pipelineName}:job-deps:${key}\"" ] job)
// (appendToAfterScript [ "finalize_nix_ci" ] job)
// (let
variables = job.variables or {} //
optionalAttrs nixConfig.enableRunnerCache {
NIX_CI_CACHE_STRATEGY = "runner";
@ -28,15 +26,13 @@ in
inherit variables;
})
// (let
cache =
(toList (job.cache or []))
++ (optional nixConfig.enableRunnerCache {
cache = (toList (job.cache or [])) ++
(optional nixConfig.enableRunnerCache {
key = nixConfig.runnerCacheKey;
paths = [".nix-cache/"];
paths = [ ".nix-cache/" ];
});
in
# filter empty cache
optionalAttrs (cache != []) {
inherit cache;
})
)

View file

@ -57,14 +57,14 @@
{
name = "jobPatched nix disabled";
expected = {
/*cache = [{
cache = [{
name = "some";
paths = [ "this" ];
}];
variables = {
BASH = toString pkgs.bash;
TEST = "work";
};*/
};
};
actual = mkJobPatched {
key = "test";
@ -206,14 +206,14 @@
before_script = [ "./init" ];
script = [ "echo Hello World!" ];
after_script = [ "./clean" ];
/*cache = [{
cache = [{
key = "simple";
paths = [ "~/random/" ];
}];
variables = {
SAMPLE = "working";
HELLO = toString pkgs.hello;
};*/
};
};
};
actual = (mkPipeline {