feat: refactor file structure module interfaces and other

default.nix

@@ -10,6 +10,8 @@ let
     inherit kubenix;
   };
 
+  # evalModules with same interface as lib.evalModules and kubenix as
+  # special argument
   evalModules = {
     module ? null,
     modules ? [module],
@@ -27,8 +29,9 @@ let
   modules = import ./modules;
 
   kubenix = {
-    inherit evalModules kubenix;
+    inherit evalModules modules;
 
     lib = kubenixLib;
-  } // modules;
+    module = modules.module;
+  };
 in kubenix

lib/default.nix

@@ -3,4 +3,5 @@
 (import ./extra.nix { inherit pkgs lib; }) // {
   k8s = import ./k8s.nix { inherit lib; };
   docker = import ./docker.nix { inherit lib pkgs; };
+  helm = import ./helm { inherit pkgs; };
 }

lib/helm/default.nix

@@ -0,0 +1,6 @@
+{ pkgs }:
+
+{
+  chart2json = pkgs.callPackage ./chart2json.nix { };
+  fetch = pkgs.callPackage ./fetchhelm.nix { };
+}

modules/default.nix

@@ -1,9 +1,10 @@
 {
+  k8s = ./k8s.nix;
+  istio = ./istio.nix;
   submodules = ./submodules.nix;
-  k8s = ./k8s;
+  helm = ./helm.nix;
-  istio = ./istio;
+  docker = ./docker.nix;
-  testing = ./testing;
+  testing = ./testing.nix;
-  helm = ./helm;
+  test = ./test.nix;
-  docker = ./docker;
   module = ./module.nix;
 }

modules/helm.nix

@@ -1,4 +1,7 @@
-{ config, lib, pkgs, kubenix, ... }:
+# helm defines kubenix module with options for using helm charts
+# with kubenix
+
+{ config, lib, pkgs, helm, ... }:
 
 with lib;
 
@@ -21,13 +24,11 @@ let
     version = last splitted;
   };
 
-  chart2json = pkgs.callPackage ./chart2json.nix {  };
-  fetchhelm = pkgs.callPackage ./fetchhelm.nix {  };
-
 in {
-  imports = [
+  imports = [ ./k8s.nix ];
-    kubenix.k8s
+
-  ];
+  # expose helm helper methods as module argument
+  config._module.args.helm = import ../lib/helm { inherit pkgs; };
 
   options.kubernetes.helm = {
     instances = mkOption {
@@ -86,19 +87,13 @@ in {
           metadata.namespace = mkDefault config.namespace;
         }];
 
-        config.objects = importJSON (chart2json {
+        config.objects = importJSON (helm.chart2json {
           inherit (config) chart name namespace values kubeVersion;
         });
       }));
     };
   };
 
-  # include helper helm methods as args
-  config._module.args.helm = {
-    fetch = fetchhelm;
-    chart2json = chart2json;
-  };
-
   config.kubernetes.api = mkMerge (flatten (mapAttrsToList (_: instance:
     map (object: let
       apiVersion = parseApiVersion object.apiVersion;

modules/istio.nix

@@ -4697,7 +4697,7 @@ let
       };
     };
 
-  } // (import ./overrides.nix {inherit definitions lib;});
+  } // (import ./istio-overrides.nix {inherit definitions lib;});
 in {
   kubernetes.customResources = [
   {

modules/k8s.nix

@@ -1,3 +1,5 @@
+# K8S module defines kubernetes definitions for kubenix
+
 { config, lib, pkgs, k8s, ... }:
 
 with lib;
@@ -108,8 +110,8 @@ let
   indexOf = lst: value:
     head (filter (v: v != -1) (imap0 (i: v: if v == value then i else -1) lst));
 in {
-  # expose k8s helper methods through arg in modules
+  # expose k8s helper methods as module argument
-  config._module.args.k8s = import ../../lib/k8s.nix { inherit lib; };
+  config._module.args.k8s = import ../lib/k8s.nix { inherit lib; };
 
   options.kubernetes.version = mkOption {
     description = "Kubernetes version to use";

modules/k8s/submodule.nix

@@ -1,59 +0,0 @@
-{ config, lib, kubenix, ... }:
-
-with lib;
-
-let
-  globalConfig = config;
-in {
-  imports = [ kubenix.submodules ];
-
-  options = {
-    kubernetes.propagateDefaults = mkOption {
-      description = "Whether to propagate child defaults to submodules";
-      type = types.bool;
-      default = true;
-    };
-
-    submodules.instances = mkOption {
-       type = types.attrsOf (types.submodule ({config, ...}: {
-        options = {
-          namespace = mkOption {
-            description = "Default kubernetes namespace";
-            type = types.str;
-            default = "default";
-          };
-        };
-
-        config.config = {
-          kubernetes.api.defaults = [{
-            default.metadata.namespace = mkDefault config.namespace;
-          }];
-        };
-      }));
-    };
-  };
-
-  config = {
-    submodules.defaults = [{
-      default = {
-        imports = [ kubenix.k8s ];
-        kubernetes.version = mkDefault config.kubernetes.version;
-        kubernetes.api.defaults =
-          mkIf config.kubernetes.propagateDefaults config.kubernetes.api.defaults;
-      };
-    } {
-      default = ({config, ...}: {
-        kubernetes.api.defaults = [{
-          default.metadata.labels = {
-            "kubenix/module-name" = config.submodule.name;
-            "kubenix/module-version" = config.submodule.version;
-          };
-        }];
-      });
-    }];
-
-    kubernetes.objects = mkMerge (mapAttrsToList (_: submodule:
-      submodule.config.kubernetes.objects
-    ) config.submodules.instances);
-  };
-}

modules/module.nix

@@ -1,11 +1,15 @@
-{ config, lib, kubenix, ... }:
+# module.nix defines default kubenix module with additional helper options
+# and preincluded kubenix module definitions for kubernetes, docker and
+# kubenix submodules
+
+{ config, lib, ... }:
 
 with lib;
 
 let
   parentConfig = config;
 in {
-  imports = with kubenix; [ submodules k8s docker ];
+  imports = [ ./k8s.nix ./docker.nix ./submodules.nix ];
 
   options = {
     kubenix.release = mkOption {
@@ -42,7 +46,7 @@ in {
   config = {
     submodules.defaults = [{
       default = {
-        imports = [ kubenix.module ];
+        imports = [ ./module.nix ];
         kubernetes.version = mkDefault config.kubernetes.version;
         kubernetes.api.defaults =
           mkIf config.kubernetes.propagateDefaults config.kubernetes.api.defaults;

tests/default.nix

@@ -16,13 +16,9 @@ let
     version' = replaceStrings ["."] ["_"] version;
   in nameValuePair "v${version'}" (kubenix.evalModules {
     modules = [
-      kubenix.testing
+      kubenix.modules.testing
 
       {
-        imports = [kubenix.k8s kubenix.submodules];
-
-        kubernetes.version = version;
-
         testing.throwError = throwError;
         testing.e2e = e2e;
         testing.tests = [
@@ -40,7 +36,7 @@ let
           ./module.nix
         ];
         testing.defaults = ({kubenix, ...}: {
-          imports = [kubenix.k8s];
+          imports = [kubenix.modules.k8s];
           kubernetes.version = version;
           _module.args.images = images;
         });

tests/helm/simple.nix

@@ -1,4 +1,4 @@
-{ config, lib, test, pkgs, kubenix, helm, ... }:
+{ config, lib, pkgs, kubenix, helm, ... }:
 
 with lib;
 with kubenix.lib;
@@ -29,9 +29,7 @@ let
     finalImageTag = "latest";
   };
 in {
-  imports = [
+  imports = [ kubenix.modules.test kubenix.modules.helm ];
-    kubenix.helm
-  ];
 
   test = {
     name = "helm-simple";

tests/istio/bookinfo.nix

@@ -1,12 +1,7 @@
-{ config, test, kubenix, k8s, ... }:
+{ config, kubenix, ... }:
-
-with k8s;
 
 {
-  imports = [
+  imports = with kubenix.modules; [ test k8s istio ];
-    kubenix.k8s
-    kubenix.istio
-  ];
 
   test = {
     name = "istio-bookinfo";

tests/k8s/1.13/crd.nix

@@ -5,9 +5,7 @@ with lib;
 let
   cfg = config.kubernetes.api.customresourcedefinitions.crontabs;
 in {
-  imports = [
+  imports = with kubenix.modules; [ test k8s ];
-    kubenix.k8s
-  ];
 
   test = {
     name = "k8s-1.13-crd";

tests/k8s/crd.nix

@@ -5,9 +5,7 @@ with lib;
 let
   cfg = config.kubernetes.api.customresourcedefinitions.crontabs;
 in {
-  imports = [
+  imports = with kubenix.modules; [ test k8s ];
-    kubenix.k8s
-  ];
 
   test = {
     name = "k8s-crd";

tests/k8s/defaults.nix

@@ -1,15 +1,12 @@
-{ config, lib, test, kubenix, k8s, ... }:
+{ config, lib, kubenix, ... }:
 
 with lib;
-with k8s;
 
 let
   pod1 = config.kubernetes.api.pods.pod1;
   pod2 = config.kubernetes.api.pods.pod2;
 in {
-  imports = [
+  imports = with kubenix.modules; [ test k8s ];
-    kubenix.k8s
-  ];
 
   test = {
     name = "k8s-defaults";

tests/k8s/deployment.nix

@@ -1,4 +1,4 @@
-{ config, lib, pkgs, test, kubenix, images, ... }:
+{ config, lib, pkgs, kubenix, images, ... }:
 
 with lib;
 
@@ -6,9 +6,7 @@ let
   cfg = config.kubernetes.api.deployments.nginx;
   image = images.nginx;
 in {
-  imports = [
+  imports = [ kubenix.modules.test kubenix.modules.k8s ];
-    kubenix.k8s
-  ];
 
   test = {
     name = "k8s-deployment";

tests/k8s/order.nix

@@ -5,9 +5,7 @@ with lib;
 let
   cfg = config.kubernetes.api.customresourcedefinitions.crontabs;
 in {
-  imports = [
+  imports = with kubenix.modules; [ test k8s ];
-    kubenix.k8s
-  ];
 
   test = {
     name = "k8s-order";

tests/k8s/simple.nix

@@ -1,13 +1,9 @@
-{ config, test, kubenix, k8s, ... }:
+{ config, kubenix, ... }:
-
-with k8s;
 
 let
   cfg = config.kubernetes.api.pods.nginx;
 in {
-  imports = [
+  imports = [ kubenix.modules.test kubenix.modules.k8s ];
-    kubenix.k8s
-  ];
 
   test = {
     name = "k8s-simple";

tests/module.nix

@@ -6,9 +6,7 @@ let
   cfg = config.submodules.instances.test.config;
   deployment = cfg.kubernetes.api.deployments.nginx;
 in {
-  imports = [
+  imports = [ kubenix.modules.test kubenix.module ];
-    kubenix.module
-  ];
 
   test = {
     name = "module";

tests/submodules/defaults.nix

@@ -21,9 +21,7 @@ let
     };
   };
 in {
-  imports = [
+  imports = with kubenix.modules; [ test submodules ];
-    kubenix.submodules
-  ];
 
   test = {
     name = "submodules-defatuls";

tests/submodules/simple.nix

@@ -5,9 +5,7 @@ with lib;
 let
   cfg = config.submodules.instances.instance;
 in {
-  imports = [
+  imports = with kubenix.modules; [ test submodules ];
-    kubenix.submodules
-  ];
 
   test = {
     name = "submodules-simple";

tests/submodules/versioning.nix

@@ -16,9 +16,7 @@ let
     };
   };
 in {
-  imports = [
+  imports = with kubenix.modules; [ test submodules ];
-    kubenix.submodules
-  ];
 
   test = {
     name = "submodules-imports";