mirror of
https://github.com/TECHNOFAB11/jsonnet-bundler.git
synced 2025-12-11 23:50:05 +01:00
* feat: go-like import style jb now creates a directory structure inside of vendor/ that is similar to how go does (github.com/grafana/jsonnet-libs). This is reflected in the final import paths, which means they will be go-like * refactor(spec/deps): named regexs * feat: make goImportStyle configurable Defaults to off, can be enabled in `jsonnetfile.json` * fix: integration test * doc: license headers * fix(deps): remove GO_IMPORT_STYLE not an option anymore, will always do so and symlink * feat: symlink to legacy location * feat: allow to disable legacy links * fix(test): legacyImports in integration tests * fix(spec): test * fix: respect legacyName aliases It was possible to alias packages by changing `name` previously. While names are now absolute (and computed), legacy links should still respect old aliases to avoid breaking code. * fix(test): integration * fix(init): keep legacyImports enabled for now * feat: rewrite imports adds a command to automatically rewrite imports from legacy to absolute style * fix(tool): rewrite confused by prefixing packages When a package was a prefix of another one, it broke. Fixed that by using a proper regular expression. Added a test to make sure it works as expected * Update cmd/jb/init.go * fix: exclude local packages from legacy linking They actually still use the old style, which is fine. LegacyLinking messed them up, but from now on it just ignores symlinks that match a localPackage.
185 lines
5.3 KiB
Go
185 lines
5.3 KiB
Go
// Copyright 2018 jsonnet-bundler authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
// +build integration
|
|
|
|
package main
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
"github.com/jsonnet-bundler/jsonnet-bundler/pkg/jsonnetfile"
|
|
"github.com/jsonnet-bundler/jsonnet-bundler/spec"
|
|
"github.com/jsonnet-bundler/jsonnet-bundler/spec/deps"
|
|
)
|
|
|
|
// TODO: Change legacyImports to false eventually
|
|
const initContents = `{"dependencies": [], "legacyImports": true}`
|
|
|
|
func TestInstallCommand(t *testing.T) {
|
|
testcases := []struct {
|
|
Name string
|
|
URIs []string
|
|
ExpectedCode int
|
|
ExpectedJsonnetFile []byte
|
|
ExpectedJsonnetLockFile []byte
|
|
}{
|
|
{
|
|
Name: "NoURLs",
|
|
ExpectedCode: 0,
|
|
ExpectedJsonnetFile: []byte(initContents),
|
|
},
|
|
{
|
|
Name: "OneURL",
|
|
URIs: []string{"github.com/jsonnet-bundler/jsonnet-bundler@v0.1.0"},
|
|
ExpectedCode: 0,
|
|
ExpectedJsonnetFile: []byte(`{"dependencies": [{"source": {"git": {"remote": "https://github.com/jsonnet-bundler/jsonnet-bundler", "subdir": ""}}, "version": "v0.1.0"}], "legacyImports": true}`),
|
|
ExpectedJsonnetLockFile: []byte(`{"dependencies": [{"source": {"git": {"remote": "https://github.com/jsonnet-bundler/jsonnet-bundler", "subdir": ""}}, "version": "080f157c7fb85ad0281ea78f6c641eaa570a582f", "sum": "W1uI550rQ66axRpPXA2EZDquyPg/5PHZlvUz1NEzefg="}], "legacyImports": false}`),
|
|
},
|
|
{
|
|
Name: "Local",
|
|
URIs: []string{"jsonnet/foobar"},
|
|
ExpectedCode: 0,
|
|
ExpectedJsonnetFile: []byte(`{"dependencies": [{"source": {"local": {"directory": "jsonnet/foobar"}}, "version": ""}], "legacyImports": true}`),
|
|
ExpectedJsonnetLockFile: []byte(`{"dependencies": [{"source": {"local": {"directory": "jsonnet/foobar"}}, "version": ""}], "legacyImports": false}`),
|
|
},
|
|
}
|
|
|
|
localDependency := "jsonnet/foobar"
|
|
|
|
cleanup := func() {
|
|
_ = os.Remove(jsonnetfile.File)
|
|
_ = os.Remove(jsonnetfile.LockFile)
|
|
_ = os.RemoveAll("vendor")
|
|
_ = os.RemoveAll("jsonnet")
|
|
}
|
|
|
|
for _, tc := range testcases {
|
|
_ = t.Run(tc.Name, func(t *testing.T) {
|
|
cleanup()
|
|
|
|
err := os.MkdirAll(localDependency, os.ModePerm)
|
|
assert.NoError(t, err)
|
|
|
|
// init + check it works correctly (legacyImports true, empty dependencies)
|
|
initCommand("")
|
|
jsonnetFileContent(t, jsonnetfile.File, []byte(initContents))
|
|
|
|
// install something, check it writes only if required, etc.
|
|
installCommand("", "vendor", tc.URIs)
|
|
jsonnetFileContent(t, jsonnetfile.File, tc.ExpectedJsonnetFile)
|
|
if tc.ExpectedJsonnetLockFile != nil {
|
|
jsonnetFileContent(t, jsonnetfile.LockFile, tc.ExpectedJsonnetLockFile)
|
|
}
|
|
})
|
|
}
|
|
|
|
cleanup()
|
|
}
|
|
|
|
func jsonnetFileContent(t *testing.T, filename string, content []byte) {
|
|
t.Helper()
|
|
|
|
bytes, err := ioutil.ReadFile(filename)
|
|
assert.NoError(t, err)
|
|
if eq := assert.JSONEq(t, string(content), string(bytes)); !eq {
|
|
t.Log(string(bytes))
|
|
}
|
|
}
|
|
|
|
func TestWriteChangedJsonnetFile(t *testing.T) {
|
|
testcases := []struct {
|
|
Name string
|
|
JsonnetFileBytes []byte
|
|
NewJsonnetFile spec.JsonnetFile
|
|
ExpectWrite bool
|
|
}{
|
|
{
|
|
Name: "NoDiffEmpty",
|
|
JsonnetFileBytes: []byte(`{}`),
|
|
NewJsonnetFile: spec.New(),
|
|
ExpectWrite: false,
|
|
},
|
|
{
|
|
Name: "NoDiffNotEmpty",
|
|
JsonnetFileBytes: []byte(`{"dependencies": [{"version": "master"}]}`),
|
|
NewJsonnetFile: spec.JsonnetFile{
|
|
Dependencies: map[string]deps.Dependency{
|
|
"": {
|
|
Version: "master",
|
|
},
|
|
},
|
|
},
|
|
ExpectWrite: false,
|
|
},
|
|
{
|
|
Name: "DiffVersion",
|
|
JsonnetFileBytes: []byte(`{"dependencies": [{"version": "1.0"}]}`),
|
|
NewJsonnetFile: spec.JsonnetFile{
|
|
Dependencies: map[string]deps.Dependency{
|
|
"": {
|
|
Version: "2.0",
|
|
},
|
|
},
|
|
},
|
|
ExpectWrite: true,
|
|
},
|
|
{
|
|
Name: "Diff",
|
|
JsonnetFileBytes: []byte(`{}`),
|
|
NewJsonnetFile: spec.JsonnetFile{
|
|
Dependencies: map[string]deps.Dependency{
|
|
"github.com/foobar/foobar": {
|
|
Source: deps.Source{
|
|
GitSource: &deps.Git{
|
|
Scheme: deps.GitSchemeHTTPS,
|
|
Host: "github.com",
|
|
User: "foobar",
|
|
Repo: "foobar",
|
|
Subdir: "",
|
|
},
|
|
},
|
|
Version: "master",
|
|
}},
|
|
},
|
|
ExpectWrite: true,
|
|
},
|
|
}
|
|
outputjsonnetfile := "changedjsonnet.json"
|
|
for _, tc := range testcases {
|
|
_ = t.Run(tc.Name, func(t *testing.T) {
|
|
clean := func() {
|
|
_ = os.Remove(outputjsonnetfile)
|
|
}
|
|
clean()
|
|
defer clean()
|
|
|
|
err := writeChangedJsonnetFile(tc.JsonnetFileBytes, &tc.NewJsonnetFile, outputjsonnetfile)
|
|
assert.NoError(t, err)
|
|
|
|
if tc.ExpectWrite {
|
|
assert.FileExists(t, outputjsonnetfile)
|
|
} else {
|
|
_, err := os.Lstat(outputjsonnetfile)
|
|
if err != nil {
|
|
assert.True(t, os.IsNotExist(err))
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|