types: disable SC2034 in checks by default and suppress SC2043 warning

This commit is contained in:
Lily Foster 2023-02-02 12:35:00 -05:00 committed by lassulus
parent 0accdf4e20
commit 7585a30385

View file

@ -199,7 +199,7 @@ rec {
*/ */
writeCheckedBash = { pkgs, checked ? false, noDeps ? false }: pkgs.writers.makeScriptWriter { writeCheckedBash = { pkgs, checked ? false, noDeps ? false }: pkgs.writers.makeScriptWriter {
interpreter = if noDeps then "/usr/bin/env bash" else "${pkgs.bash}/bin/bash"; interpreter = if noDeps then "/usr/bin/env bash" else "${pkgs.bash}/bin/bash";
check = lib.optionalString checked "${pkgs.shellcheck}/bin/shellcheck"; check = lib.optionalString checked "${pkgs.shellcheck}/bin/shellcheck -e SC2034";
}; };
@ -252,6 +252,7 @@ rec {
set -efux set -efux
umount -Rv "${rootMountPoint}" || : umount -Rv "${rootMountPoint}" || :
# shellcheck disable=SC2043
for dev in ${toString (lib.catAttrs "device" (lib.attrValues devices.disk))}; do for dev in ${toString (lib.catAttrs "device" (lib.attrValues devices.disk))}; do
${../disk-deactivate}/disk-deactivate "$dev" | bash -x ${../disk-deactivate}/disk-deactivate "$dev" | bash -x
done done