technofab/dbmate
1
0
Fork 0
mirror of https://github.com/TECHNOFAB11/dbmate.git synced 2025-12-11 23:50:04 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add gometalinter (#36)

Browse source
This commit is contained in:
Adrian Macneil 2018-04-15 19:59:56 -07:00 • committed by GitHub
parent cacf5de3ec
commit ee3162c34c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 32 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

26
.gometalinter.json Normal file
View file

@ -0,0 +1,26 @@
{
"Sort": ["linter", "severity", "path", "line"],
"WarnUnmatchedDirective": true,
"DisableAll": true,
"Enable": [
"deadcode",
"errcheck",
"gocyclo",
"gofmt",
"goimports",
"golint",
"interfacer",
"lll",
"maligned",
"megacheck",
"misspell",
"nakedret",
"structcheck",
"unconvert",
"unparam",
"varcheck",
"vet"
],
"Cyclo": 12,
"LineLength": 100
}

5
Dockerfile
View file

@ -15,9 +15,8 @@ RUN apt-get update \
# development dependencies # development dependencies
RUN curl -fsSL -o /usr/local/bin/dep https://github.com/golang/dep/releases/download/v0.3.2/dep-linux-amd64 \ RUN curl -fsSL -o /usr/local/bin/dep https://github.com/golang/dep/releases/download/v0.3.2/dep-linux-amd64 \
&& chmod +x /usr/local/bin/dep && chmod +x /usr/local/bin/dep
RUN go get \ RUN go get gopkg.in/alecthomas/gometalinter.v2 \
github.com/golang/lint/golint \ && gometalinter.v2 --install
github.com/kisielk/errcheck
# copy source files # copy source files
COPY . /go/src/github.com/amacneil/dbmate COPY . /go/src/github.com/amacneil/dbmate

4
Makefile
View file

@ -19,9 +19,7 @@ test:
.PHONY: lint .PHONY: lint
lint: lint:
golint -set_exit_status $(PACKAGES) gometalinter.v2 $(PACKAGES)
go vet $(PACKAGES)
errcheck $(PACKAGES)
.PHONY: clean .PHONY: clean
clean: clean:

4
main_test.go
View file

@ -11,9 +11,7 @@ import (
) )
func testContext(t *testing.T, u *url.URL) *cli.Context { func testContext(t *testing.T, u *url.URL) *cli.Context {
var err error err := os.Setenv("DATABASE_URL", u.String())
err = os.Setenv("DATABASE_URL", u.String())
require.Nil(t, err) require.Nil(t, err)
app := NewApp() app := NewApp()

6
pkg/dbmate/db.go
View file

@ -182,11 +182,7 @@ func (db *DB) NewMigration(name string) error {
defer mustClose(file) defer mustClose(file)
_, err = file.WriteString(migrationTemplate) _, err = file.WriteString(migrationTemplate)
if err != nil { return err
return err
}
return nil
} }
func doTransaction(db *sql.DB, txFunc func(Transaction) error) error { func doTransaction(db *sql.DB, txFunc func(Transaction) error) error {

2
pkg/dbmate/mysql.go
View file

@ -105,7 +105,7 @@ func mysqldumpArgs(u *url.URL) []string {
if username := u.User.Username(); username != "" { if username := u.User.Username(); username != "" {
args = append(args, "--user="+username) args = append(args, "--user="+username)
} }
// mysql recommands against using environment variables to supply password // mysql recommends against using environment variables to supply password
// https://dev.mysql.com/doc/refman/5.7/en/password-security-user.html // https://dev.mysql.com/doc/refman/5.7/en/password-security-user.html
if password, set := u.User.Password(); set { if password, set := u.User.Password(); set {
args = append(args, "--password="+password) args = append(args, "--password="+password)