Add --url flag (#150)

This commit is contained in:
Adrian Macneil 2020-08-08 11:19:33 -07:00 committed by GitHub
parent d1b3334ff7
commit a9aaaad1fb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 41 additions and 19 deletions

View file

@ -2,7 +2,6 @@ package main
import (
"flag"
"net/url"
"os"
"testing"
@ -10,30 +9,34 @@ import (
"github.com/urfave/cli/v2"
)
func testContext(t *testing.T, u *url.URL) *cli.Context {
err := os.Setenv("DATABASE_URL", u.String())
require.NoError(t, err)
func TestGetDatabaseUrl(t *testing.T) {
// set environment variables
require.NoError(t, os.Setenv("DATABASE_URL", "foo://example.org/one"))
require.NoError(t, os.Setenv("CUSTOM_URL", "foo://example.org/two"))
app := NewApp()
flagset := flag.NewFlagSet(app.Name, flag.ContinueOnError)
for _, f := range app.Flags {
_ = f.Apply(flagset)
require.NoError(t, f.Apply(flagset))
}
ctx := cli.NewContext(app, flagset, nil)
return cli.NewContext(app, flagset, nil)
}
func TestGetDatabaseUrl(t *testing.T) {
envURL, err := url.Parse("foo://example.org/db")
require.NoError(t, err)
ctx := testContext(t, envURL)
// no flags defaults to DATABASE_URL
u, err := getDatabaseURL(ctx)
require.NoError(t, err)
require.Equal(t, "foo://example.org/one", u.String())
require.Equal(t, "foo", u.Scheme)
require.Equal(t, "example.org", u.Host)
require.Equal(t, "/db", u.Path)
// --env overwrites DATABASE_URL
require.NoError(t, ctx.Set("env", "CUSTOM_URL"))
u, err = getDatabaseURL(ctx)
require.NoError(t, err)
require.Equal(t, "foo://example.org/two", u.String())
// --url takes precedence over preceding two options
require.NoError(t, ctx.Set("url", "foo://example.org/three"))
u, err = getDatabaseURL(ctx)
require.NoError(t, err)
require.Equal(t, "foo://example.org/three", u.String())
}
func TestRedactLogString(t *testing.T) {