Properly check errors from sql.Rows (#170)

.golangci.yml

@@ -11,6 +11,7 @@ linters:
     - ineffassign
     - misspell
     - nakedret
+    - rowserrcheck
     - staticcheck
     - structcheck
     - typecheck

pkg/dbmate/clickhouse.go

@@ -243,6 +243,10 @@ func (drv ClickHouseDriver) SelectMigrations(db *sql.DB, limit int) (map[string]
 		migrations[version] = true
 	}
 
+	if err = rows.Err(); err != nil {
+		return nil, err
+	}
+
 	return migrations, nil
 }
 

pkg/dbmate/mysql.go

@@ -223,6 +223,10 @@ func (drv MySQLDriver) SelectMigrations(db *sql.DB, limit int) (map[string]bool,
 		migrations[version] = true
 	}
 
+	if err = rows.Err(); err != nil {
+		return nil, err
+	}
+
 	return migrations, nil
 }
 

pkg/dbmate/postgres.go

@@ -258,6 +258,10 @@ func (drv PostgresDriver) SelectMigrations(db *sql.DB, limit int) (map[string]bo
 		migrations[version] = true
 	}
 
+	if err = rows.Err(); err != nil {
+		return nil, err
+	}
+
 	return migrations, nil
 }
 

pkg/dbmate/sqlite.go

@@ -148,6 +148,10 @@ func (drv SQLiteDriver) SelectMigrations(db *sql.DB, limit int) (map[string]bool
 		migrations[version] = true
 	}
 
+	if err = rows.Err(); err != nil {
+		return nil, err
+	}
+
 	return migrations, nil
 }